Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 24 Apr 2019 17:55:05 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Bo YU <tsu.yubo@gmail.com>
Cc:     gregkh@linuxfoundation.org, christian.gromm@microchip.com,
        colin.king@canonical.com, andrey.shvetsov@k2l.de,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: most: protect potential string overflow
Message-ID: <20190424145505.GE14798@kadam>
References: <20190423022018.12214-1-tsu.yubo@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190423022018.12214-1-tsu.yubo@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Apr 22, 2019 at 10:20:18PM -0400, Bo YU wrote:
> There maybe cause potential string overflow issue due to use
> strcpy without checking the length
> 
> Detected By CoversityScan CID# 1444760
> 
> Fixes: 131ac62253dba:(staging: most: core: use device description as name)

It doesn't really fix anything, it just silences a static checker
warning.

> Signed-off-by: Bo YU <tsu.yubo@gmail.com>
> ---
>  drivers/staging/most/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/most/core.c b/drivers/staging/most/core.c
> index 956daf8c3bd2..0f26cebac91a 100644
> --- a/drivers/staging/most/core.c
> +++ b/drivers/staging/most/core.c
> @@ -1431,7 +1431,7 @@ int most_register_interface(struct most_interface *iface)
>  
>  	INIT_LIST_HEAD(&iface->p->channel_list);
>  	iface->p->dev_id = id;
> -	strcpy(iface->p->name, iface->description);
> +	strlcpy(iface->p->name, iface->description, sizeof(iface->p->name));

We prefer strscpy() more than strlcpy() these days.

regards,
dan carpenter