Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1088265yba; Wed, 24 Apr 2019 14:54:59 -0700 (PDT) X-Google-Smtp-Source: APXvYqys7ugs7CXv6FWC0U179ecMPmXRivaCcmy3E2bGL+rfFezWd6FMnmsPkdAHl7AFa0FdVgJd X-Received: by 2002:a63:6907:: with SMTP id e7mr32205039pgc.209.1556142899495; Wed, 24 Apr 2019 14:54:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556142899; cv=none; d=google.com; s=arc-20160816; b=xWn4J8pTLwwE5+T+oNRIn1D6gl96j9/Zo4F7XJXdBa0Z2/lY0bZxItsTzTrjFnxsLr DBxOQdXcRoyoESQS/BNpZl9vgzjRv0eoF3JO2Fw1luVTVX8rHZ8DX7tv9Ruq1AaA8ntA Fkv7ucY+kOWzjk762Fz8xcZCFuaIpyzisdZWR1s050lqtKXcSS/F7ZqPCH7Dt0liY9Zq mYfaqlnLNZRoU4pG44irvIfBxZCFSsJ/zKm2bFUczear053JUKNt/ERQs86+R/1+39en TTY+A2exNoKfd8Cw3x70oGk7T6F5ifylwaHZZEIIIaa0YorZ6uPX6KzyoyNjqHtOCGUs DiRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :dkim-signature; bh=2x5quoMOq6Ix9IsSIlE/PYCVevSKJlmqyPJVJGAn6QQ=; b=0eaBtPNypFM/3NIluRGgyRK8V0iv0drVbifQyei90+a5Ib0/pY32KwJ86MenN7zAku Daja0sm0UawPhUhCxiRW5jfpgTt2OB6zWe29YX1iXddhKYuYPESUQgyC0N7+U7N/xGcF KTZbVIfYQ5o/gevoASzEYkl8rgEXZG6uil9eJCpMon412JYYAq+icywhFQVVaa2V5v6s gG5OlWr1ouTmHhr7tA8xatutm/CXdwvl7n4wf+122+1hBbB9JYhtkp7s2s4pw52PmAmJ 10EsWsgh65xuEQbtk5plgutUfkwh8dSw06j2fyKwemADHXc6YMqH/7MRRd4xnGEVWfvT GF6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=EhuUE2Eb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n34si20384615pld.352.2019.04.24.14.54.43; Wed, 24 Apr 2019 14:54:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=EhuUE2Eb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731734AbfDXPqk (ORCPT + 99 others); Wed, 24 Apr 2019 11:46:40 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:38098 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727327AbfDXPqj (ORCPT ); Wed, 24 Apr 2019 11:46:39 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x3OFcx7M151856; Wed, 24 Apr 2019 15:46:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=2x5quoMOq6Ix9IsSIlE/PYCVevSKJlmqyPJVJGAn6QQ=; b=EhuUE2EbNfUSCr3afzSGOGP2JgCYSWG4wt6EVh7kOWHz4xQqUQ0aqVxIhTFygbdubKqi eBdmieKS0H7PxyOy/4j1jpZehFuJOM6t591MKSLkCtmyGKuvnBf78OkktUUMpe0PPOCb IMtDbzdl1yqNsHkRGPIM9Epy4hP53MCaLhaMvW2yy6+hvQihsDkp849nHJg3QucHMNAf Bef0EdAMOIRLkBGbbtPIJxeuEU337w74SarpWQvhhLIGaFG25CUWjrG5l6Lbo4R7NEq4 YoiXt9bH+PESwNUew6I06EO3nhQY60kpZJDlBammMEpRKfif4uR6aeiKRx4fZyiNhdTs Fw== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2120.oracle.com with ESMTP id 2ryv2qb6xm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 24 Apr 2019 15:46:14 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x3OFiTD6071426; Wed, 24 Apr 2019 15:46:13 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3020.oracle.com with ESMTP id 2s0fv3n4we-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 24 Apr 2019 15:46:13 +0000 Received: from abhmp0015.oracle.com (abhmp0015.oracle.com [141.146.116.21]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x3OFkCfO013455; Wed, 24 Apr 2019 15:46:12 GMT Received: from bostrovs-us.us.oracle.com (/10.152.32.65) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 24 Apr 2019 08:46:12 -0700 Subject: Re: [PATCH v2 2/2] xen/pvh: correctly setup the PV EFI interface for dom0 To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: linux-kernel@vger.kernel.org, Juergen Gross , Stefano Stabellini , Darren Hart , Andy Shevchenko , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , x86@kernel.org, xen-devel@lists.xenproject.org, platform-driver-x86@vger.kernel.org References: <20190423130416.68935-1-roger.pau@citrix.com> <20190423130416.68935-2-roger.pau@citrix.com> <2359c97c-1125-cfd2-44c2-7e9ce7972558@oracle.com> <20190424154504.vzkkobxsesc3oval@Air-de-Roger> From: Boris Ostrovsky Openpgp: preference=signencrypt Autocrypt: addr=boris.ostrovsky@oracle.com; prefer-encrypt=mutual; keydata= mQINBFH8CgsBEAC0KiOi9siOvlXatK2xX99e/J3OvApoYWjieVQ9232Eb7GzCWrItCzP8FUV PQg8rMsSd0OzIvvjbEAvaWLlbs8wa3MtVLysHY/DfqRK9Zvr/RgrsYC6ukOB7igy2PGqZd+M MDnSmVzik0sPvB6xPV7QyFsykEgpnHbvdZAUy/vyys8xgT0PVYR5hyvhyf6VIfGuvqIsvJw5 C8+P71CHI+U/IhsKrLrsiYHpAhQkw+Zvyeml6XSi5w4LXDbF+3oholKYCkPwxmGdK8MUIdkM d7iYdKqiP4W6FKQou/lC3jvOceGupEoDV9botSWEIIlKdtm6C4GfL45RD8V4B9iy24JHPlom woVWc0xBZboQguhauQqrBFooHO3roEeM1pxXjLUbDtH4t3SAI3gt4dpSyT3EvzhyNQVVIxj2 FXnIChrYxR6S0ijSqUKO0cAduenhBrpYbz9qFcB/GyxD+ZWY7OgQKHUZMWapx5bHGQ8bUZz2 SfjZwK+GETGhfkvNMf6zXbZkDq4kKB/ywaKvVPodS1Poa44+B9sxbUp1jMfFtlOJ3AYB0WDS Op3d7F2ry20CIf1Ifh0nIxkQPkTX7aX5rI92oZeu5u038dHUu/dO2EcuCjl1eDMGm5PLHDSP 0QUw5xzk1Y8MG1JQ56PtqReO33inBXG63yTIikJmUXFTw6lLJwARAQABtDNCb3JpcyBPc3Ry b3Zza3kgKFdvcmspIDxib3Jpcy5vc3Ryb3Zza3lAb3JhY2xlLmNvbT6JAjgEEwECACIFAlH8 CgsCGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEIredpCGysGyasEP/j5xApopUf4g 9Fl3UxZuBx+oduuw3JHqgbGZ2siA3EA4bKwtKq8eT7ekpApn4c0HA8TWTDtgZtLSV5IdH+9z JimBDrhLkDI3Zsx2CafL4pMJvpUavhc5mEU8myp4dWCuIylHiWG65agvUeFZYK4P33fGqoaS VGx3tsQIAr7MsQxilMfRiTEoYH0WWthhE0YVQzV6kx4wj4yLGYPPBtFqnrapKKC8yFTpgjaK jImqWhU9CSUAXdNEs/oKVR1XlkDpMCFDl88vKAuJwugnixjbPFTVPyoC7+4Bm/FnL3iwlJVE qIGQRspt09r+datFzPqSbp5Fo/9m4JSvgtPp2X2+gIGgLPWp2ft1NXHHVWP19sPgEsEJXSr9 tskM8ScxEkqAUuDs6+x/ISX8wa5Pvmo65drN+JWA8EqKOHQG6LUsUdJolFM2i4Z0k40BnFU/ kjTARjrXW94LwokVy4x+ZYgImrnKWeKac6fMfMwH2aKpCQLlVxdO4qvJkv92SzZz4538az1T m+3ekJAimou89cXwXHCFb5WqJcyjDfdQF857vTn1z4qu7udYCuuV/4xDEhslUq1+GcNDjAhB nNYPzD+SvhWEsrjuXv+fDONdJtmLUpKs4Jtak3smGGhZsqpcNv8nQzUGDQZjuCSmDqW8vn2o hWwveNeRTkxh+2x1Qb3GT46uuQINBFH8CgsBEADGC/yx5ctcLQlB9hbq7KNqCDyZNoYu1HAB Hal3MuxPfoGKObEktawQPQaSTB5vNlDxKihezLnlT/PKjcXC2R1OjSDinlu5XNGc6mnky03q yymUPyiMtWhBBftezTRxWRslPaFWlg/h/Y1iDuOcklhpr7K1h1jRPCrf1yIoxbIpDbffnuyz kuto4AahRvBU4Js4sU7f/btU+h+e0AcLVzIhTVPIz7PM+Gk2LNzZ3/on4dnEc/qd+ZZFlOQ4 KDN/hPqlwA/YJsKzAPX51L6Vv344pqTm6Z0f9M7YALB/11FO2nBB7zw7HAUYqJeHutCwxm7i BDNt0g9fhviNcJzagqJ1R7aPjtjBoYvKkbwNu5sWDpQ4idnsnck4YT6ctzN4I+6lfkU8zMzC gM2R4qqUXmxFIS4Bee+gnJi0Pc3KcBYBZsDK44FtM//5Cp9DrxRQOh19kNHBlxkmEb8kL/pw XIDcEq8MXzPBbxwHKJ3QRWRe5jPNpf8HCjnZz0XyJV0/4M1JvOua7IZftOttQ6KnM4m6WNIZ 2ydg7dBhDa6iv1oKdL7wdp/rCulVWn8R7+3cRK95SnWiJ0qKDlMbIN8oGMhHdin8cSRYdmHK kTnvSGJNlkis5a+048o0C6jI3LozQYD/W9wq7MvgChgVQw1iEOB4u/3FXDEGulRVko6xCBU4 SQARAQABiQIfBBgBAgAJBQJR/AoLAhsMAAoJEIredpCGysGyfvMQAIywR6jTqix6/fL0Ip8G jpt3uk//QNxGJE3ZkUNLX6N786vnEJvc1beCu6EwqD1ezG9fJKMl7F3SEgpYaiKEcHfoKGdh 30B3Hsq44vOoxR6zxw2B/giADjhmWTP5tWQ9548N4VhIZMYQMQCkdqaueSL+8asp8tBNP+TJ PAIIANYvJaD8xA7sYUXGTzOXDh2THWSvmEWWmzok8er/u6ZKdS1YmZkUy8cfzrll/9hiGCTj u3qcaOM6i/m4hqtvsI1cOORMVwjJF4+IkC5ZBoeRs/xW5zIBdSUoC8L+OCyj5JETWTt40+lu qoqAF/AEGsNZTrwHJYu9rbHH260C0KYCNqmxDdcROUqIzJdzDKOrDmebkEVnxVeLJBIhYZUd t3Iq9hdjpU50TA6sQ3mZxzBdfRgg+vaj2DsJqI5Xla9QGKD+xNT6v14cZuIMZzO7w0DoojM4 ByrabFsOQxGvE0w9Dch2BDSI2Xyk1zjPKxG1VNBQVx3flH37QDWpL2zlJikW29Ws86PHdthh Fm5PY8YtX576DchSP6qJC57/eAAe/9ztZdVAdesQwGb9hZHJc75B+VNm4xrh/PJO6c1THqdQ 19WVJ+7rDx3PhVncGlbAOiiiE3NOFPJ1OQYxPKtpBUukAlOTnkKE6QcA4zckFepUkfmBV1wM Jg6OxFYd01z+a+oL Message-ID: <131ff20e-5f28-40ef-37a0-422f6508c115@oracle.com> Date: Wed, 24 Apr 2019 11:45:43 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190424154504.vzkkobxsesc3oval@Air-de-Roger> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9237 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=892 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904240120 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9237 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=909 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904240120 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/24/19 11:45 AM, Roger Pau Monné wrote: > On Wed, Apr 24, 2019 at 11:36:41AM -0400, Boris Ostrovsky wrote: >> On 4/23/19 9:04 AM, Roger Pau Monne wrote: >>> This involves initializing the boot params EFI related fields and the >>> efi global variable. >>> >>> Without this fix a PVH dom0 doesn't detect when booted from EFI, and >>> thus doesn't support accessing any of the EFI related data. >>> >>> Reported-by: PGNet Dev >>> Signed-off-by: Roger Pau Monné >> Hmm.. This seems to be breaking save/restore for me (for domU), and I >> can't see any obvious reasons. >> >> Can you try it? > Sure, thanks for the extra testing! I have to admit I haven't tested > save/restore with this patch applied, it didn't come to mind it might > affect that functionality. > > I assume it's save/restore of a PVH domU that's broken (HVM and PV are > fine)? > PV is fine, I haven't tried HVM. -boris