Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261186AbVA0Umm (ORCPT ); Thu, 27 Jan 2005 15:42:42 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261180AbVA0Uml (ORCPT ); Thu, 27 Jan 2005 15:42:41 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:50896 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S261182AbVA0Um0 (ORCPT ); Thu, 27 Jan 2005 15:42:26 -0500 Date: Thu, 27 Jan 2005 20:42:17 +0000 From: Christoph Hellwig To: Rik van Riel Cc: Arjan van de Ven , linux-kernel@vger.kernel.org, akpm@osdl.org, torvalds@osdl.org Subject: Re: Patch 4/6 randomize the stack pointer Message-ID: <20050127204217.GA2481@infradead.org> Mail-Followup-To: Christoph Hellwig , Rik van Riel , Arjan van de Ven , linux-kernel@vger.kernel.org, akpm@osdl.org, torvalds@osdl.org References: <20050127101117.GA9760@infradead.org> <20050127101322.GE9760@infradead.org> <20050127202335.GA2033@infradead.org> <20050127202720.GA12390@infradead.org> <20050127203206.GA2180@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 938 Lines: 25 On Thu, Jan 27, 2005 at 03:40:48PM -0500, Rik van Riel wrote: > On Thu, 27 Jan 2005, Christoph Hellwig wrote: > > >>+unsigned long arch_align_stack(unsigned long sp) > >>+{ > >>+ if (randomize_va_space) > >>+ sp -= ((get_random_int() % 4096) << 4); > >>+ return sp & ~0xf; > >>+} > > > >this looks like it'd work nicely on all architectures. > > I guess it should work for all architectures using ELF, > not sure if it might break some of the more obscure > architectures ... So it works for all CONFIG_MMU architectures. Arjan mentioned that the minimum stack alignment might be different, so the 4 should become a per-arch constant and we can make the code unconditional for CONFIG_MMU? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/