Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1151674yba; Wed, 24 Apr 2019 16:14:19 -0700 (PDT) X-Google-Smtp-Source: APXvYqzPM065kEHFIf0S1z3wHmYEfQJO5zvc63z3g6jG3mXVQ4shwS97DgxEhQDu5pKAaMfFaRaL X-Received: by 2002:a65:480c:: with SMTP id h12mr32876541pgs.266.1556147659312; Wed, 24 Apr 2019 16:14:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556147659; cv=none; d=google.com; s=arc-20160816; b=gTCj12/DMZgK1ldkp7cS1AIkWhKSXw3zzZtOJ3ypAsObmM4jdej/u47EbwHbvrfiQz TIkPN0olxQ2+tGnIKyR1+oR9mRNDbHIRz8n4h2/5uekh/D+VA4uGpKUNOP2A22YwgOjz BXaTW8hRekBlOrm6j3mSTs/i0iJMoG6AkL0+6qaC/64rjLsBIgVrdAoVGLwrbtoYdP1P iNxvz34mGYexT2Sk0CjjnNgtDqaOd/zfpJ8QbnBUB00BJdHm+1+74dNiOCGUvGkDqa9f 1Vjw8jJnVYymDTIioZvZ95xTIV4TeNctWeCDvI3qUL4EfmPTG7ma+hwOIRu0eadWd1nX wMaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=F1zuQ56RG7SiURqTfEHuaH9RCnwUEced5x5Pm1w0ly8=; b=k+Jjo2StP29Vlnmb2YXYPbA+I/YcSsvr7dLGTn4o6tF06L6e4eENsgn4cwyWSPF9Bj pBE99RH8RkYwMHlRcgWFenkOcm34BWQeSIeZ9CajbHUFI5yT9IkljkkS+l/6WQKKbZWE FFaVTPEkmQph6695OOdBPReUmrlVk7U7KZx+iD9yvKpOIX2aHk0DMFQL1RzpH5wPNISR eH9Crq8Nk2RAKa6zQGrCMBnWWm/neBaIyhrFIazo9PxtbLz6l+tJocw6kZSueMZuviCn 8cTzKbV8mBsd0UxocCnfbG/1WGz4sDdn2cCUL/pNFpOMtYeENJWG34rqKgtB/Bp97Ttm Hpmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=DsSMVYUy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r35si11533016pgl.410.2019.04.24.16.14.04; Wed, 24 Apr 2019 16:14:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=DsSMVYUy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389163AbfDXRU0 (ORCPT + 99 others); Wed, 24 Apr 2019 13:20:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:45666 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389154AbfDXRUW (ORCPT ); Wed, 24 Apr 2019 13:20:22 -0400 Received: from localhost (62-193-50-229.as16211.net [62.193.50.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C6382205ED; Wed, 24 Apr 2019 17:20:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556126421; bh=qdUeN1YLhpiBlZwvdf2IfQ0OpwD/83RG08fUEnWpIHo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DsSMVYUy9O0y8cAkPznt5eKLzL+anp1TIDGEV/V6eKf4Iw82TZkbG9ZFHkqtfKsnN 8kLhBYig5JQN+SPjEZWT5+LauVHLeQ8esy2Ap8T7GHPScuW+sARYRSgckW3e/86mCn V5L+ZZJPwnoX1PTb4AwVz7+q4XvYEa5K6y+8t6Q8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Colin Ian King , Takashi Iwai , Sasha Levin Subject: [PATCH 4.4 105/168] ALSA: opl3: fix mismatch between snd_opl3_drum_switch definition and declaration Date: Wed, 24 Apr 2019 19:09:09 +0200 Message-Id: <20190424170929.807101451@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190424170923.452349382@linuxfoundation.org> References: <20190424170923.452349382@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit b4748e7ab731e436cf5db4786358ada5dd2db6dd ] The function snd_opl3_drum_switch declaration in the header file has the order of the two arguments on_off and vel swapped when compared to the definition arguments of vel and on_off. Fix this by swapping them around to match the definition. This error predates the git history, so no idea when this error was introduced. Signed-off-by: Colin Ian King Signed-off-by: Takashi Iwai Signed-off-by: Sasha Levin --- sound/drivers/opl3/opl3_voice.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/drivers/opl3/opl3_voice.h b/sound/drivers/opl3/opl3_voice.h index a371c075ac87..e26702559f61 100644 --- a/sound/drivers/opl3/opl3_voice.h +++ b/sound/drivers/opl3/opl3_voice.h @@ -41,7 +41,7 @@ void snd_opl3_timer_func(unsigned long data); /* Prototypes for opl3_drums.c */ void snd_opl3_load_drums(struct snd_opl3 *opl3); -void snd_opl3_drum_switch(struct snd_opl3 *opl3, int note, int on_off, int vel, struct snd_midi_channel *chan); +void snd_opl3_drum_switch(struct snd_opl3 *opl3, int note, int vel, int on_off, struct snd_midi_channel *chan); /* Prototypes for opl3_oss.c */ #ifdef CONFIG_SND_SEQUENCER_OSS -- 2.19.1