Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Vakul Garg <vakul.garg@nxp.com>
To:     Jakub Kicinski <jakub.kicinski@netronome.com>,
        Wenwen Wang <wang6495@umn.edu>
CC:     Boris Pismenny <borisp@mellanox.com>,
        Aviad Yehezkel <aviadye@mellanox.com>,
        Dave Watson <davejwatson@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        Daniel Borkmann <daniel@iogearbox.net>,
        "David S. Miller" <davem@davemloft.net>,
        "open list:NETWORKING [TLS]" <netdev@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] net: tls: fix a memory leak bug
Thread-Topic: [PATCH] net: tls: fix a memory leak bug
Thread-Index: AQHU+trepvsmBbb/oUSYaUK+00Q4HaZMESAAgAA72/A=
Date:   Thu, 25 Apr 2019 04:44:15 +0000
Message-ID: <VE1PR04MB66708069A751DD3B7174E4F98B3D0@VE1PR04MB6670.eurprd04.prod.outlook.com>
References: <1556137087-25814-1-git-send-email-wang6495@umn.edu>
 <20190424180840.515b88af@cakuba.netronome.com>
In-Reply-To: <20190424180840.515b88af@cakuba.netronome.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 4fb767f7-0d97-4f15-8f3f-08d6c938abf3
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Apr 2019 04:44:15.7829
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6413
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Jakub Kicinski <jakub.kicinski@netronome.com>
> Sent: Thursday, April 25, 2019 6:39 AM
> To: Wenwen Wang <wang6495@umn.edu>
> Cc: Boris Pismenny <borisp@mellanox.com>; Aviad Yehezkel
> <aviadye@mellanox.com>; Dave Watson <davejwatson@fb.com>; John
> Fastabend <john.fastabend@gmail.com>; Daniel Borkmann
> <daniel@iogearbox.net>; David S. Miller <davem@davemloft.net>; open
> list:NETWORKING [TLS] <netdev@vger.kernel.org>; open list <linux-
> kernel@vger.kernel.org>; Vakul Garg <vakul.garg@nxp.com>
> Subject: Re: [PATCH] net: tls: fix a memory leak bug
>=20
> On Wed, 24 Apr 2019 15:18:07 -0500, Wenwen Wang wrote:
> > In decrypt_internal(), a memory block 'mem' is allocated through
> > kmalloc() to hold aead_req, sgin[], sgout[], aad, and iv. This memory
> > block should be freed after it is used, before this function is
> > returned. However, if the return value of the function invocation of
> > tls_do_decryption() is -EINPROGRESS, this memory block is actually not
> > freed, which is a memory leak bug.
> >
> > To fix this issue, free the allocated block before the error code
> > -EINPROGRESS is returned.
> >
> > Signed-off-by: Wenwen Wang <wang6495@umn.edu>
>=20
> Did you find this by code inspection or is this provable at runtime (kmem=
leak
> or such)?
>=20
> > diff --git a/net/tls/tls_sw.c b/net/tls/tls_sw.c index
> > b50ced8..22445bb 100644
> > --- a/net/tls/tls_sw.c
> > +++ b/net/tls/tls_sw.c
> > @@ -1445,8 +1445,10 @@ static int decrypt_internal(struct sock *sk,
> struct sk_buff *skb,
> >  	/* Prepare and submit AEAD request */
> >  	err =3D tls_do_decryption(sk, skb, sgin, sgout, iv,
> >  				data_len, aead_req, async);
> > -	if (err =3D=3D -EINPROGRESS)
> > +	if (err =3D=3D -EINPROGRESS) {
> > +		kfree(mem);
> >  		return err;
>=20
> Mm... don't think so.
>=20
> -EINPROGRESS is special, it means something is working on the request
> asynchronously here.
>=20
> I think this memory is freed in tls_decrypt_done():
>=20
> 	kfree(aead_req);
>=20
> Note that aead_req is the first member of the allocated buffer.
>=20
> CCing Vakul

The patch is wrong.=20
Valid reasons have been given against the patch.

>=20
> > +	}
> >
> >  	/* Release the pages in case iov was mapped to pages */
> >  	for (; pages > 0; pages--)