Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1861340yba; Thu, 25 Apr 2019 06:57:40 -0700 (PDT) X-Google-Smtp-Source: APXvYqwZ2yOIFZLHqnPLwRbb8i/xxv9JIUKsrmac6pGFHmREautJri569kVyraOsYRVBxyC1L1P5 X-Received: by 2002:a17:902:8f8f:: with SMTP id z15mr26091279plo.131.1556200660843; Thu, 25 Apr 2019 06:57:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556200660; cv=none; d=google.com; s=arc-20160816; b=AuBFGf6ssaF9JlOO6ZHeFXEfpF0sOUNdrsWw5K3OI76aLx/yGUSIX/x4AZiryi6MSe WsSNIxyce6CT9Tclk512Qs/0lAJwk6mkjP3flixQCeP2nZrMockAHk2ou0Ivw45dhJbo qFnBIf3aMkIq5Hr9dppZ9NeDCu7lmD0B6mrDuuQ0zWfskqRkn2I8ShlO34/APIsUymCi mw3IYrXTjd2KZDYsM0y3vSP4DUiqJ0WcBgk2UHF3nRh6Spju4cpIWaNCT6XxrmwMsvmB mUOwd/bp8tKUJa8gQmtLlDEz2LPY9cH/t8HG/BzBvotW3FU/C8hG2gu/SSz3eAJYW2Fg u49A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=nbWbckl3ngTUwbzqQScg2PakfSDB4GnW9hW6/QyYb1E=; b=j+wNNCAc6qFdjwEY2NfL97hVNYAD6vuPZNsGnPkoE/kZSUj6gkpgrkHvt2E3QQDB4z il0mP343Q+szlSAdI3F7upa1XNBMO/vo24bJ/RehAIh8xx5XhUb+0bGHa2LZ+4P42Rd9 REarFYdjAYDrO7FGpsojIpaSnj+tIwrPks54tcMOVdar8SHAjkJJZRO4/yhSI4nL3w1m HCyok5g6IF+wNW5npR1aBZf1MRCe+t9PpSh7wI5PofyW2oqU5NrESXRU5pdIQ/FD6Tzm 5RNnvpPatGghyNTHZfBskkb72suUt1DVsy/5ihlbY2/ENUTozI565SBeJCb1WgLsg5po c3UQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v23si4483140pfm.186.2019.04.25.06.57.25; Thu, 25 Apr 2019 06:57:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729121AbfDYM3p (ORCPT + 99 others); Thu, 25 Apr 2019 08:29:45 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:49729 "EHLO relay1-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726067AbfDYM3p (ORCPT ); Thu, 25 Apr 2019 08:29:45 -0400 X-Originating-IP: 90.88.147.33 Received: from localhost.localdomain (aaubervilliers-681-1-27-33.w90-88.abo.wanadoo.fr [90.88.147.33]) (Authenticated sender: paul.kocialkowski@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id AD73C240011; Thu, 25 Apr 2019 12:29:39 +0000 (UTC) From: Paul Kocialkowski To: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Eric Anholt , David Airlie , Daniel Vetter , Maxime Ripard , Eben Upton , Paul Kocialkowski Subject: [PATCH v7 0/4] drm/vc4: Binner BO management improvements Date: Thu, 25 Apr 2019 14:29:13 +0200 Message-Id: <20190425122917.26536-1-paul.kocialkowski@bootlin.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Changes since v6: * Removed vc4_v3d_bin_bo_put from error paths; * Added WARN_ON_ONCE when no bin BO at refcount release. Changes since v5: * Fix more locking mistakes; * Introduce get/put helpers; * Grabbed a reference when submitting an exec job with a binner slot. * Addressed misc comments. Changes since v4: * Used a kref on the binner bo instead of firstopen/lastclose; * Added a mutex to prevent race conditions; * Took care of enabling the OOM interrupt when we have a binner BO allocated. Changes since v3: * Split changes into more commits when possible; * Reworked binner bo alloc condition as discussed. Changes since v2: * Removed deprecated sentence about fristopen; * Added collected Reviewed-By tags. Changes since v1: * Squashed the two final patches into one. Paul Kocialkowski (4): drm/vc4: Reformat and the binner bo allocation helper drm/vc4: Check for V3D before binner bo alloc drm/vc4: Check for the binner bo before handling OOM interrupt drm/vc4: Allocate binner bo when starting to use the V3D drivers/gpu/drm/vc4/vc4_bo.c | 33 ++++++++++++++++- drivers/gpu/drm/vc4/vc4_drv.c | 6 ++++ drivers/gpu/drm/vc4/vc4_drv.h | 14 ++++++++ drivers/gpu/drm/vc4/vc4_gem.c | 13 +++++++ drivers/gpu/drm/vc4/vc4_irq.c | 20 ++++++++--- drivers/gpu/drm/vc4/vc4_v3d.c | 68 ++++++++++++++++++++++++++--------- 6 files changed, 132 insertions(+), 22 deletions(-) -- 2.21.0