Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1976698yba; Thu, 25 Apr 2019 08:41:14 -0700 (PDT) X-Google-Smtp-Source: APXvYqwwp+mrGf36Xp3QsVNV5au4m6s526g2S4BASYbU3BB8lEZqZCH0i81fWKq2mg1CE+lCsKI/ X-Received: by 2002:a17:902:2b87:: with SMTP id l7mr40285148plb.130.1556206874846; Thu, 25 Apr 2019 08:41:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556206874; cv=none; d=google.com; s=arc-20160816; b=OKuceNDxC41RnSi72UYKU7BORZ1lQk/GvQFyc0xh5BqyCWBf6JioV1qUhQhrhEv9kb tFrMk/xI5DqbzZVOzy6tgX1Bd0Kc1abhl2wgQXTAnFNrO/A//zwKaU7OBRwlmmSAc/UF U6u8Lj11Tqv/i3oLqpNUb6v/f2og3ewZJAHwjmT4xjWglr4loWYvm872lDlJwPZngk3l uaYlbznnXx/jqHJu7mnwhv2p1wURTk+qgQVgRaET5RswDdwVBzBeKUth6ymqVCXDKP73 M/R8hd2s4aWUc5uhvy7PWjbOB+rP4BIV5BRBlLFG+rDB+sPfHCHr1LAYvKSniiuVP76N up9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Ox/A/M9f/YJNR/OkLo5ELVLHceNW1+cEY/T228JWq9Y=; b=Sx9an/UvA4Ee0R2XNckK6ORrJThfzPuiYkKgG9J9GTq37ZZFwtotDFDt9k0c55bR6f ohLRZnEd1mo7CsEKs8tXjGYwFPXCZ1VAH7q1CY0b4AJlf8bQzRCQM8aUcA95X3r6y2cn gR5ceDIVkw9qlh3D05//GwkawtprYbpoO322aysOXvVv1yzjUr8vHjgBdIDNnFCLxF+M FKa3oHyWfRV9goZxOez7gAmpQd8LKH/fxogheq5XiX1UfNnFl9n1NxV/Z/gR1k7AVhxw 8WVHSVE8urWgFkSynNlbUWFLSv6tJ6KvENnvvsnNTkAb0ui+EUA+N13UOpU+VWeU7h5O axPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=itxzsdnc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i8si22722684pfd.275.2019.04.25.08.40.59; Thu, 25 Apr 2019 08:41:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=itxzsdnc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727146AbfDYOjG (ORCPT + 99 others); Thu, 25 Apr 2019 10:39:06 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:44874 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726102AbfDYOjF (ORCPT ); Thu, 25 Apr 2019 10:39:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Ox/A/M9f/YJNR/OkLo5ELVLHceNW1+cEY/T228JWq9Y=; b=itxzsdncAJJfxbIzDH3h8NzPR fTlTV7kliuirFPDQxRXM985hM+at1g/HkjfahIi1OLeEUCaf+KAVX02YgICFj+UNhHIUOpgPaLsiS YDBAzty13rzlzEOKjNy1EHM2hkjZdYRCcGSpDlJCNEuwVZ6WzpEzAlD/KBV01xSyj5Y9GaUoPJT01 +8xZAcOHZeFmcoDdzYD72TonxajqOfTLu4zinLJg/XzJawVjhnIszArCawp7iPVn0SZFHPQXnGAGE mmcsE7ie4qmHCf49khEqFd98M1+pdz+T1HqLHtxcT92hPPHgy3Q9wpUaP4GyY39eOrbBXwXxqz5Fe WZQDNK7ig==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1hJfWg-0000sH-RV; Thu, 25 Apr 2019 14:39:02 +0000 Date: Thu, 25 Apr 2019 07:39:02 -0700 From: Christoph Hellwig To: Aaron Ma Cc: Keith Busch , keith.busch@intel.com, axboe@fb.com, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, Maxim Levitsky Subject: Re: [PATCH] nvme: determine the number of IO queues Message-ID: <20190425143902.GA30715@infradead.org> References: <1555510379-20199-1-git-send-email-aaron.ma@canonical.com> <096935354b16662eb481aeda1f48001ba489463c.camel@redhat.com> <20190418134820.GA7589@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 18, 2019 at 10:21:03PM +0800, Aaron Ma wrote: > > > On 4/18/19 9:48 PM, Keith Busch wrote: > > It does change the default behavior. If I have a degraded controller that > > can't do IO in a machine with 1000's of CPUs, I have to iterate this > > non-standard behavior 1000's of times before the drive is servicable > > again. We currenlty figure that out in just a single try. > > > > At least the quirks document *why* the driver is doing non-standard > > behavior. We do the IO queue quirks for Macbooks, for example. > > > > But why don't you file a bug report with the device vendor instead? Surely > > a firmware fix provides the best possible outcome, and would make this > > device work not only in all versions of Linux, but also every standard > > compliant driver for any OS. > > I will do it, no v2 for now. Honestly, unless this is a device shiping in a max market consumer product already I don't think we should work around this crap at all, given that this device has obviously never been tested at all. It really needs a firmware fix instead of a host workaround.