Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2102998yba; Thu, 25 Apr 2019 10:39:07 -0700 (PDT) X-Google-Smtp-Source: APXvYqwuaDbHLy+lqcwzSgPr003Sdve32APe//DQbUmgKKgmuSFaAwzBw0KZHVdw3Q3nrd30ntQR X-Received: by 2002:a62:6c43:: with SMTP id h64mr42037482pfc.123.1556213947688; Thu, 25 Apr 2019 10:39:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556213947; cv=none; d=google.com; s=arc-20160816; b=0spMKflIOSbIdhIdPlMnAVTu9M7M8FSUtSYiAVckYoKW7VLVMKqHmbF5m8g12wXuZR jLfwUKAkyiVuh3K/cu9NJVgpmPKcZ1v9Dr9zajVoMKaA0QCVqMuDsHnkBoKs4waFnnga UaTVgg0bJB3dNMUrPP0oFnlDNcRwFSk0th5bqcPu00m2p4ITvDhsrM6O4kzWcQblXA2W +KNSOkSjI1Qj4/k7SXaaKlJzl6BUujzI8uRkJ4oqYyeys/cn/K4b4nrKhPU+Er850Toj qE0LwI/+rHveVQW8kL+xjmSjLBcy5FUqixDTIj/0FCKdpHr35hPNlS28CYCKVwTgJWVA RiJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from; bh=Jry71DpjOUTIz00YFFxjNz5yYjcIxvfQCp3FKj6Kwgw=; b=eSwF4u9GmxS4a57RaFToTUhkAUg0VxB4cOS+cbUVlZ6Zg3FCP3DcRecFH6O1lOLjKH GOq5Ee4WblVVgGPx0whzarFdAyVivZaVYB//rv+ICas+zoOx9OSupLzdGTE+7eL8nbZb bnZoWqEpkTdymIUkF9voJHcfU1TgLUdL30qDhFfarohmGBQ0KZsroLyNwLNDjfVxcSq+ 9BCSDUpXFkbIHur5HAptQkDWjfOEgqAj0ln93EQWB9eAXvouTQZsIHpNsEbeaWmXoEZs eZ5ACKcF1HwO8py9rNebFajU8O4lH8AtsiSjKKeWETrdSN5To7vYnmwKHzKA9I6VV91r qHvA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k5si5995560pll.254.2019.04.25.10.38.52; Thu, 25 Apr 2019 10:39:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731279AbfDYMmB (ORCPT + 99 others); Thu, 25 Apr 2019 08:42:01 -0400 Received: from mga03.intel.com ([134.134.136.65]:62207 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725965AbfDYMmA (ORCPT ); Thu, 25 Apr 2019 08:42:00 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Apr 2019 05:42:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,393,1549958400"; d="asc'?scan'208";a="134292877" Received: from pipin.fi.intel.com (HELO pipin) ([10.237.72.175]) by orsmga007.jf.intel.com with ESMTP; 25 Apr 2019 05:41:54 -0700 From: Felipe Balbi To: Douglas Anderson , Minas Harutyunyan , heiko@sntech.de Cc: Alan Stern , Artur Petrosyan , amstan@chromium.org, linux-rockchip@lists.infradead.org, William Wu , linux-usb@vger.kernel.org, Stefan Wahren , Randy Li , zyw@rock-chips.com, mka@chromium.org, ryandcase@chromium.org, Amelie Delaunay , jwerner@chromium.org, dinguyen@opensource.altera.com, Elaine Zhang , Douglas Anderson , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/5] USB: dwc2: Don't turn off the usbphy in suspend if wakeup is enabled In-Reply-To: <20190418001356.124334-5-dianders@chromium.org> References: <20190418001356.124334-1-dianders@chromium.org> <20190418001356.124334-5-dianders@chromium.org> Date: Thu, 25 Apr 2019 15:41:50 +0300 Message-ID: <87mukes1dd.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Douglas Anderson writes: > If the 'snps,need-phy-for-wake' is set in the device tree then: > > - We know that we can wakeup, so call device_set_wakeup_capable(). > The USB core will use this knowledge to enable wakeup by default. > - We know that we should keep the PHY on during suspend if something > on our root hub needs remote wakeup. This requires the patch (USB: > Export usb_wakeup_enabled_descendants()). Note that we don't keep > the PHY on at suspend time if it's not needed because it would be a > power draw. > > If we later find some users of dwc2 that can support wakeup without > keeping the PHY on we may want to add a way to call > device_set_wakeup_capable() without keeping the PHY on at suspend > time. > > Signed-off-by: Douglas Anderson > Signed-off-by: Chris Zhong checking file drivers/usb/dwc2/core.h Hunk #1 FAILED at 861. Hunk #2 FAILED at 1049. 2 out of 2 hunks FAILED checking file drivers/usb/dwc2/platform.c Hunk #3 FAILED at 487. Hunk #4 succeeded at 513 (offset -9 lines). Hunk #5 succeeded at 543 (offset -9 lines). Hunk #6 succeeded at 556 (offset -9 lines). 1 out of 6 hunks FAILED =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlzBqw4ACgkQzL64meEa mQbVCxAApSaX0S5csF9prSld7aWLI8sHAR7AKO7ORr1SGmtZrsW/68If6MgGPheM GRpQpq+UhyxqXnwUm3jcn+DXWaYC4p1K0r/SCksJRiUiF1CaxW46IH7fuCtYLqcD SQWTEg6Co8rpLXNe6YWAiGiT1Z1cFyL2CFZKiy6jn5yN3jd3nIpbGs4gFpc0GAzp mm1RJL1iSkuuDKm8+SlAcLAxxn/l2ARFMthzVvDSvwcFUmhpZyK15KkH5NFBZuEX m+aIz75H2Cd7hwhOvKiV+3UahD6VlOBV9Va8GaQv5MHsm3Cris7L2+PzUK6289BK slOQyh/X5xSPyixnbQ7ytEgC9+h4mgSwHJAdbTfkU1GHSvse/DhkKF9lLM7AcaRh EdF2MdIeeyqyHx0OrdMvoBGWHhy2m8C04dW2+YBKeIFEwhfZkPkw1SvIwpo7f8It ffTghKVOjYaK/TbR5ohAesqo+/yKmG+GgmfQZlcQ6sFALVBxmj+aaFSMo6R125j8 CvH3zVfXYsgnz4iYcKkz1VXyddu0NDD0Ml6A1L7pq1dwxINaukkk68QyC9euMAF0 SdsGIGIWl20/2tDKjtkTzIdRujTnDPbNqiiOyMviQvo30KxZcfNMPzMtV96MJ13U X5PjJyRNxe4yULEUuXrnGCvTwD/mIif/3OJfh6n0SW28cD2A/dA= =+55D -----END PGP SIGNATURE----- --=-=-=--