Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2212393yba; Thu, 25 Apr 2019 12:30:16 -0700 (PDT) X-Google-Smtp-Source: APXvYqwQOIeT7uq50U3uHehh5uWLIV4x16nPc9sHdteyCwhuaKxd3sZrA3+4NCiaJprdFi5MTz0m X-Received: by 2002:aa7:8e59:: with SMTP id d25mr3257088pfr.24.1556220616618; Thu, 25 Apr 2019 12:30:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556220616; cv=none; d=google.com; s=arc-20160816; b=Gl5CLWJXNNvz4RDxYJOCG8sDWm7EaC7Bjo8Cmrz5p7gIaxDEsRYRvV7XPnwN/7TL/t voIG2D9A+hksX15dVa0i4DrifT5Ci7brUrKR6JizwbZUl4llhTn61HPUHkQV/myi/A8t Nzw49K2N+g+HJlXL8UJ6QnfVJvyyqsMsxee9wqvFRdWEZfYwUBr7yAzUoKb1PAi0Ty7N ltKjzWj+qKJk3fxpq49kKHCI9gKrGAxGpiFl1KhJkuAZubwraiZZwxnWYkwmSYJFz7HG RLSvnQtJL1MdbvU1X7lVc2YPO5rEz32qnLnePJnQ6UXVeYYA23Z2w3zlgE/bMk00YAFN oTng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:in-reply-to:subject:cc:to :from:dkim-signature; bh=Qh/tQSJgW5cW1WWM314yAbyJG2XgZz7T3I4K/Vf7Tzc=; b=LqgZoY7CjIwR5mB1v/fcR5uySPaxwQUTqoA4aNdRHmoH/7emwELyAICmTSJLx3J78P j36nWGoSKMlH0s7um5K6dqdVSpa3h5YdK96kUhP44gdxlE28bZRAGec9l6RL+kUH3anZ 9nZX3+TvYPIOW9qOMWnnP6BBGwsDMdNH4z+x4F52BH1NeqhwIOzpF+hTqOBdFcVV1w7r HkhHguyV71D0z2yDE3iLzyKhwo2ZfF3JfCSzS2ESbtCPyvHvrYjcHx6p2gdoJ6v92Ane xF4kYLMzRiziszbcvKAnrSLw7NjiczGvxjCmvPRewmWEJzjxPXbkLdItbZLwlsDrLMIH BDVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=vQFP07+H; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g127si22087420pgc.135.2019.04.25.12.30.01; Thu, 25 Apr 2019 12:30:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=vQFP07+H; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728227AbfDYT1S (ORCPT + 99 others); Thu, 25 Apr 2019 15:27:18 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:52808 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730490AbfDYT0p (ORCPT ); Thu, 25 Apr 2019 15:26:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=Qh/tQSJgW5cW1WWM314yAbyJG2XgZz7T3I4K/Vf7Tzc=; b=vQFP07+Hbwrh +bxFr8018r8GauSebmjDitsx5C2KG22evQsJaE6Zn52b6en36UrwVq8UEwbGPO4GNSx7fr1PqKWa1 G2OJHOeKoq54ARJJDQ5paqX0HGdXVFk1tymSvKyaYnoaOdJy9nDmYJBwBst7QR23pdGPVoNt+rtBd 6qaLk=; Received: from 188.29.164.24.threembb.co.uk ([188.29.164.24] helo=finisterre.ee.mobilebroadband) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hJk11-0004f0-Hu; Thu, 25 Apr 2019 19:26:39 +0000 Received: by finisterre.ee.mobilebroadband (Postfix, from userid 1000) id AD0EC441D3C; Thu, 25 Apr 2019 20:26:38 +0100 (BST) From: Mark Brown To: Fabien Dessenne Cc: Alexandre Torgue , Christophe KERELLO , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Ludovic Barre , Mark Brown , Maxime Coquelin Subject: Applied "spi: stm32-qspi: manage the get_irq error case" to the spi tree In-Reply-To: <1556119140-3319-1-git-send-email-fabien.dessenne@st.com> X-Patchwork-Hint: ignore Message-Id: <20190425192638.AD0EC441D3C@finisterre.ee.mobilebroadband> Date: Thu, 25 Apr 2019 20:26:38 +0100 (BST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch spi: stm32-qspi: manage the get_irq error case has been applied to the spi tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-5.2 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From 9852254537c499110f6eb32f00a63d8049d04a69 Mon Sep 17 00:00:00 2001 From: Fabien Dessenne Date: Wed, 24 Apr 2019 17:19:00 +0200 Subject: [PATCH] spi: stm32-qspi: manage the get_irq error case During probe, check the "get_irq" error value. Signed-off-by: Fabien Dessenne Acked-by: Ludovic Barre Signed-off-by: Mark Brown --- drivers/spi/spi-stm32-qspi.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/spi/spi-stm32-qspi.c b/drivers/spi/spi-stm32-qspi.c index 11a89aa15d56..42f8e3c6aa1f 100644 --- a/drivers/spi/spi-stm32-qspi.c +++ b/drivers/spi/spi-stm32-qspi.c @@ -574,6 +574,12 @@ static int stm32_qspi_probe(struct platform_device *pdev) } irq = platform_get_irq(pdev, 0); + if (irq < 0) { + if (irq != -EPROBE_DEFER) + dev_err(dev, "IRQ error missing or invalid\n"); + return irq; + } + ret = devm_request_irq(dev, irq, stm32_qspi_irq, 0, dev_name(dev), qspi); if (ret) { -- 2.20.1