Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2212876yba; Thu, 25 Apr 2019 12:30:42 -0700 (PDT) X-Google-Smtp-Source: APXvYqyKGcvzTeiXea/l5WSJMb4y6x6+bOamzF8Sxs99WvxNuXbk1sm1uWEH/Fn88vkkwAxV91uM X-Received: by 2002:a63:1654:: with SMTP id 20mr3730930pgw.166.1556220642084; Thu, 25 Apr 2019 12:30:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556220642; cv=none; d=google.com; s=arc-20160816; b=O5jjJW98tAw4RcO97nYlO/eZJ79T+R4tPdr3qhll/6j6H2XurZxBCWO7xRGTKF2gro 9qkerZm4+McmXgDv9Zs+TSMfHT3VeSPDueSYPWCeXfXxfNe8XcmTNhe+Q3uuKrtlNh2H TuEXfUhVoaTURnjFLtK7mvoVhBcevz6ocV8+dFrbvuynhdTrqSLvONDwQAwH6zikwd5l H7ByiZD5RqAw53/INcCe10+e690OJFZMvTaDcvLqhVSyI2XrXIaYE/QW4+XBudFgy826 RYTyvwIWry1BZtP8J1HX9GehxNUjNb4hKXotytx7FQw6geE+qWrCaJgUNEuFhcWtiMNM Y91Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:in-reply-to:subject:cc:to :from:dkim-signature; bh=0x8Te4hhEI/xHQ81yHY2umN/dm6b1QkiuOwRSKt2718=; b=VqkikcTh6n3OhUjjSoxyIgyNP6JVZjRKHengno3Qkg7Hm830pRsru6MT+wVR7RVHcX DfMmW9fnr/VOqmi6BbqWtClb5stoK4jqt9j3YYw+br2i2xd4iHMUniRhPDnPNMU+4irT s2nNYEapzpFTpNjhiG2VVG6bStHXjj9y3bAErQcD2VcxazXsyHJkUFvzNQjwaHjSVHca BWpM22ZHAltYRuI5XbnDlDrWMbfyeZgwFfs0yoCv1SnagLQ35l4+zZ3r0oPFYePLU5uQ ew9Koa2FunaYapIF8CHlRmliQuHtXkBbn90kIprlsvF6x6ZKuhGO4+aGE3ZWYBWMGLKE ibag== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=jVa+AwOy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l3si22717729pff.78.2019.04.25.12.30.27; Thu, 25 Apr 2019 12:30:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=jVa+AwOy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730457AbfDYT0m (ORCPT + 99 others); Thu, 25 Apr 2019 15:26:42 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:52582 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728710AbfDYT0k (ORCPT ); Thu, 25 Apr 2019 15:26:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=0x8Te4hhEI/xHQ81yHY2umN/dm6b1QkiuOwRSKt2718=; b=jVa+AwOyI/tU 6/oY5p6SQXhKOHbUYbi0bexXOU8/Ex0nWWnnJIDsoCubQWikOWd1gWIMBBoeZNPf3WCJTBM7YSq/Q 5ATS31HrzhWU3apdyfvAFf/DKAQpNa0IbzGMYYs6gtZTrzkqH+4QcrXMtrEqD1TjKCTFMyuUdRt2K 5Y0g0=; Received: from 188.29.164.24.threembb.co.uk ([188.29.164.24] helo=finisterre.ee.mobilebroadband) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hJk0y-0004e5-Lz; Thu, 25 Apr 2019 19:26:36 +0000 Received: by finisterre.ee.mobilebroadband (Postfix, from userid 1000) id A0209441D3C; Thu, 25 Apr 2019 20:26:35 +0100 (BST) From: Mark Brown To: Jorge Ramirez-Ortiz Cc: broonie@kernel.org, jorge.ramirez-ortiz@linaro.org, khasim.mohammed@linaro.org, lgirdwood@gmail.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Brown Subject: Applied "regulator: core: do not report EPROBE_DEFER as error but as debug" to the regulator tree In-Reply-To: <20190417192443.6501-1-jorge.ramirez-ortiz@linaro.org> X-Patchwork-Hint: ignore Message-Id: <20190425192635.A0209441D3C@finisterre.ee.mobilebroadband> Date: Thu, 25 Apr 2019 20:26:35 +0100 (BST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch regulator: core: do not report EPROBE_DEFER as error but as debug has been applied to the regulator tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-5.2 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From 4d0a83b904f4b2b9b814ad950472b50e7e803716 Mon Sep 17 00:00:00 2001 From: Jorge Ramirez-Ortiz Date: Wed, 17 Apr 2019 21:24:43 +0200 Subject: [PATCH] regulator: core: do not report EPROBE_DEFER as error but as debug Temporary failures to get a regulator (EPROBE_DEFER) should be logged as debug information instead of errors. Signed-off-by: Jorge Ramirez-Ortiz Signed-off-by: Mark Brown --- drivers/regulator/core.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index 5a9ebcf7fe7a..08ccabe07fe3 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -4345,8 +4345,6 @@ int regulator_bulk_get(struct device *dev, int num_consumers, consumers[i].supply); if (IS_ERR(consumers[i].consumer)) { ret = PTR_ERR(consumers[i].consumer); - dev_err(dev, "Failed to get supply '%s': %d\n", - consumers[i].supply, ret); consumers[i].consumer = NULL; goto err; } @@ -4355,6 +4353,13 @@ int regulator_bulk_get(struct device *dev, int num_consumers, return 0; err: + if (ret != -EPROBE_DEFER) + dev_err(dev, "Failed to get supply '%s': %d\n", + consumers[i].supply, ret); + else + dev_dbg(dev, "Failed to get supply '%s', deferring\n", + consumers[i].supply); + while (--i >= 0) regulator_put(consumers[i].consumer); -- 2.20.1