Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2326734yba; Thu, 25 Apr 2019 14:36:32 -0700 (PDT) X-Google-Smtp-Source: APXvYqy379BxqJP5p9/9+fh000m0zT6Y/XNYHeK3wyJ/3ffp3HatZPdyscKdPeWdIzIEv4PYaDZz X-Received: by 2002:a65:6658:: with SMTP id z24mr10337458pgv.323.1556228192328; Thu, 25 Apr 2019 14:36:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556228192; cv=none; d=google.com; s=arc-20160816; b=krjXmYcqJ9lFomKRj+qMsySzxD0MCD5UBvIEXag8MfJscLcPMBx6XWkPGwf4obUX0i JlYTkwnRFneCZWk/ZPm6kGVmGd78oTjC5ZUe9R9aOQwtNa4Uqx+22R3fEzuEqsFVpMEk 7ZmXadzsStZ0bVPbJ8EkNUYVAYOgfO9wSW1z5Au6EnEOfmNl4sBIjd9OnvDUPLS0YQxk 8tXxgbFMl9RLSvZ5do1vloA/JBZRKezGQM+pAVdqSnu3vCBWMWQpuopOU8ssms8yPG7A vIWdeNNGg8tm9kiHJ4y40lWHQVRR4Tl1jri06zIzzvsrTZQBOkXUete5tlRC/dRgHymt yh6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=GfxYqWaXpjNR7LK7i4LsPRRgPJeb/GnO1gEeqtsBVsI=; b=kYZyFwA2FAqwF1GND4xMNjmLHfjCGde1QWxYTm/3XWc/QheJKs8P7iEWG66aeREFpC HwJ8TiaUkPvwiPSMVUv0P4RAyBvjnLvEZOc8bDATt50cEXlCZORlgqYTuLi0cf1KGBT+ xYBKLpI9YcNCPiAMk2X1YAS16ohkY0fONZg8ZjRbJNVBxtocUfESJV5t1OtOKD03axFn yp+QUnCkUGkRsHOI7quQ6piTm7QRqi5+A6k7Zb/c/zp6SmaRoHwu8fVJZIX5JQHG3jRs HZkiJgz38L2uBnETkZiHl2fbPT5dbXQA90oHhD4pXLf7ZjbuUvRYo26ZcwLUvyYKTd0/ NEQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b="OVN//KQl"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o6si16752080pgn.407.2019.04.25.14.36.17; Thu, 25 Apr 2019 14:36:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b="OVN//KQl"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729352AbfDYS4r (ORCPT + 99 others); Thu, 25 Apr 2019 14:56:47 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:39204 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725900AbfDYS4r (ORCPT ); Thu, 25 Apr 2019 14:56:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=GfxYqWaXpjNR7LK7i4LsPRRgPJeb/GnO1gEeqtsBVsI=; b=OVN//KQlDhGo0wx6Wn1zAH3v5 iqJDPypXGLrYCJGgPOX+P6uttkfZBruXkttjMFGGlJ4/LiO6W495UMkYsZBRn+WEFxPEVQcO481o+ CFo1e5Vqv4TmE1/VTt13rHN9OFsXGnKGoXi/rE6O0CFjZys30MhBqEPwSNwQaDrIXORqBIluZFlQH tvGdbRepAwB4hZzPxvIeK1fAv1jAT89OS7EJnpkWOSPlGXXUsEB6MqLeYmnOMfmbl9ZyKHbZU6/7T b99BHlRad9niZXbSM9W/WrmAznoG9d39gH5pyvQ1EVPe1kn2y8c6F2SUOX3A4rrmZ9R+E3w6UATvp sv+yGoXAQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1hJjY3-0006FD-Fk; Thu, 25 Apr 2019 18:56:43 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 1EF2F20321925; Thu, 25 Apr 2019 20:56:41 +0200 (CEST) Date: Thu, 25 Apr 2019 20:56:41 +0200 From: Peter Zijlstra To: Yuyang Du Cc: will.deacon@arm.com, mingo@kernel.org, bvanassche@acm.org, ming.lei@redhat.com, frederic@kernel.org, tglx@linutronix.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH 00/28] Optimize IRQ usage checks and other small bits Message-ID: <20190425185641.GT12232@hirez.programming.kicks-ass.net> References: <20190424101934.51535-1-duyuyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190424101934.51535-1-duyuyang@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 24, 2019 at 06:19:06PM +0800, Yuyang Du wrote: > Yuyang Du (28): > locking/lockdep: Change all print_*() return type to void > locking/lockdep: Add description and explanation in lockdep design doc > locking/lockdep: Adjust lock usage bit character checks > locking/lockdep: Remove useless conditional macro > locking/lockdep: Print the right depth for chain key colission > locking/lockdep: Update obsolete struct field description > locking/lockdep: Use lockdep_init_task for task initiation > consistently > locking/lockdep: Define INITIAL_CHAIN_KEY for chain keys to start with > locking/lockdep: Change the range of class_idx in held_lock struct > locking/lockdep: Remove unused argument in validate_chain() and > check_deadlock() > locking/lockdep: Update comment > locking/lockdep: Change type of the element field in circular_queue > locking/lockdep: Change the return type of __cq_dequeue() > locking/lockdep: Avoid constant checks in __bfs by using offset > reference > locking/lockdep: Update comments on dependency search > locking/lockdep: Add explanation to lock usage rules in lockdep design > doc > locking/lockdep: Remove redundant argument in check_deadlock > locking/lockdep: Remove unused argument in __lock_release Those look really good (but don't readily apply to tip/locking/core) now let me try and look at the real changes.. > locking/lockdep: Optimize irq usage check when marking lock usage bit > locking/lockdep: Refactorize check_noncircular and check_redundant > locking/lockdep: Consolidate lock usage bit initialization > locking/lockdep: Adjust new bit cases in mark_lock > locking/lockdep: Update irqsafe lock bitmaps > locking/lockdep: Remove !dir in lock irq usage check > locking/lockdep: Implement new IRQ usage checking algorithm > locking/lockdep: Remove __bfs > locking/lockdep: Remove locks_before > locking/lockdep: Reduce lock_list_entries by half