Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2328188yba; Thu, 25 Apr 2019 14:38:31 -0700 (PDT) X-Google-Smtp-Source: APXvYqwtc5W+J4sDtM8+mdqhiAQ2EpmNHBY+T/Ns3ZqQEkkb3w5TVww41yEzH60l5dhuNhrBPik5 X-Received: by 2002:a17:902:f215:: with SMTP id gn21mr31162023plb.146.1556228311569; Thu, 25 Apr 2019 14:38:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556228311; cv=none; d=google.com; s=arc-20160816; b=kR0Djj+6JewScI59rJBhbbfE9f/yQyaYOymkMJGkOYIc+aaaoimyCwG0c4tDHhaCch F4KH7Y8532/bFVa7FdssTezxn6MjAU6G2c4kQYho+xXbiCFHV6ANIXCZg+FmOtnXv8tT xm3M2WT6T3/6gVIS04FCdpLY6V1KG/UKjA4x3va8XNZlILyMlnKAcFftDyf/8/xCrftL j7it78o+GPIIpK6VymqaggfpChqYtMEaJC5uxgynjA4ra8LLCQptepjeb9xIMwdIP/ms 97KAuiuDD3s4bwTXoYLyRSWnTOVUymgKo1J02HktRNHwAz30g4DJAZHz1vE84GySsbdO afpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:in-reply-to:subject:cc:to :from:dkim-signature; bh=Qh/tQSJgW5cW1WWM314yAbyJG2XgZz7T3I4K/Vf7Tzc=; b=iPMrlQImk74ovrkJ/V05HL+tlCQLW4D8yYUFzWVpnfI5eD0xuYrvjj3bXIAh57UuEB dX2+ZQFOXMc1xo5wTwQ782sv+WOHnnDm3BH7rtrUIHAILQvoj4ohU5B49roITNjY1VaQ 3UzqlArnQLTZnYWaW3oHB5KutsJAbgzxZ4TbOUq1E2eYzHylOBjZ5mE0cT1kDK8MuiEi zAfaMLji3SiZNHTBT0sr+efThVbXb9hmDwplnivuo6EBmdC5yqfGZTCit802zHuQ0Mwh qLzezZBuGA2SL8hFviZAFd9SFFSJJpDys/Qrmdbw2qY8/6W+gYTbb05rkCuk7EREI31r p4oA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=TbFSJpL+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d6si22854512pls.402.2019.04.25.14.38.16; Thu, 25 Apr 2019 14:38:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=TbFSJpL+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387418AbfDYTZa (ORCPT + 99 others); Thu, 25 Apr 2019 15:25:30 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:49350 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727804AbfDYTYv (ORCPT ); Thu, 25 Apr 2019 15:24:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=Qh/tQSJgW5cW1WWM314yAbyJG2XgZz7T3I4K/Vf7Tzc=; b=TbFSJpL+GmeY wtWZSaFtwoB3+Vi2mxfmstO7fPofhJi42HGbmZZ3CUgEgJyL416kjkRg94WNEgcMR0OLJjkYCrqG1 ik0SNIeLEp/5vEkA6o5Tk+Wl3tshAGOxh7M4Vd/vxTLBBCOjMvrXvkcMeYWuMtRe9KtmaDLanWcwX GdHlE=; Received: from 188.29.164.24.threembb.co.uk ([188.29.164.24] helo=finisterre.ee.mobilebroadband) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hJjzB-0004a6-7A; Thu, 25 Apr 2019 19:24:45 +0000 Received: by finisterre.ee.mobilebroadband (Postfix, from userid 1000) id 8880E441D3B; Thu, 25 Apr 2019 20:24:43 +0100 (BST) From: Mark Brown To: Fabien Dessenne Cc: Alexandre Torgue , Christophe KERELLO , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Ludovic Barre , Mark Brown , Maxime Coquelin Subject: Applied "spi: stm32-qspi: manage the get_irq error case" to the spi tree In-Reply-To: <1556119140-3319-1-git-send-email-fabien.dessenne@st.com> X-Patchwork-Hint: ignore Message-Id: <20190425192443.8880E441D3B@finisterre.ee.mobilebroadband> Date: Thu, 25 Apr 2019 20:24:43 +0100 (BST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch spi: stm32-qspi: manage the get_irq error case has been applied to the spi tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-5.2 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From 9852254537c499110f6eb32f00a63d8049d04a69 Mon Sep 17 00:00:00 2001 From: Fabien Dessenne Date: Wed, 24 Apr 2019 17:19:00 +0200 Subject: [PATCH] spi: stm32-qspi: manage the get_irq error case During probe, check the "get_irq" error value. Signed-off-by: Fabien Dessenne Acked-by: Ludovic Barre Signed-off-by: Mark Brown --- drivers/spi/spi-stm32-qspi.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/spi/spi-stm32-qspi.c b/drivers/spi/spi-stm32-qspi.c index 11a89aa15d56..42f8e3c6aa1f 100644 --- a/drivers/spi/spi-stm32-qspi.c +++ b/drivers/spi/spi-stm32-qspi.c @@ -574,6 +574,12 @@ static int stm32_qspi_probe(struct platform_device *pdev) } irq = platform_get_irq(pdev, 0); + if (irq < 0) { + if (irq != -EPROBE_DEFER) + dev_err(dev, "IRQ error missing or invalid\n"); + return irq; + } + ret = devm_request_irq(dev, irq, stm32_qspi_irq, 0, dev_name(dev), qspi); if (ret) { -- 2.20.1