Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 25 Apr 2019 15:45:05 -0700 (PDT)
From:   David Rientjes <rientjes@google.com>
To:     Joel Savitz <jsavitz@redhat.com>
cc:     linux-kernel@vger.kernel.org, Rafael Aquini <aquini@redhat.com>
Subject: Re: [PATCH] mm/oom_killer: Add task UID to info message on an oom
 kill
In-Reply-To: <1556130013-19021-1-git-send-email-jsavitz@redhat.com>
Message-ID: <alpine.DEB.2.21.1904251544070.34263@chino.kir.corp.google.com>
References: <1556130013-19021-1-git-send-email-jsavitz@redhat.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 24 Apr 2019, Joel Savitz wrote:

> In the event of an oom kill, useful information about the killed
> process is printed to dmesg. Users, especially system administrators,
> will find it useful to immediately see the UID of the process.
> 
> In the following example, abuse_the_ram is the name of a program
> that attempts to iteratively allocate all available memory until it is
> stopped by force.
> 
> Current message:
> 
> Out of memory: Killed process 35389 (abuse_the_ram)
> total-vm:133718232kB, anon-rss:129624980kB, file-rss:0kB,
> shmem-rss:0kB
> 
> Patched message:
> 
> Out of memory: Killed process 2739 (abuse_the_ram), UID 0,
> total-vm:133880028kB, anon-rss:129754836kB, file-rss:0kB,
> shmem-rss:0kB
> 
> Signed-off-by: Joel Savitz <jsavitz@redhat.com>

Makes sense, could you add it to the end of the message in case anybody is 
parsing the current string and we would now break their regex?

This would also need from_kuid(&init_user_ns, task_uid(task)) instead.