Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1556234338.2788.1.camel@HansenPartnership.com>
Subject: Re: [PATCH v2 2/5 RFC] use event name instead of enum to make the
 call generic
From:   James Bottomley <James.Bottomley@HansenPartnership.com>
To:     James Morris <jmorris@namei.org>,
        Linus Torvalds <torvalds@linux-foundation.org>
Cc:     prsriva <prsriva@linux.microsoft.com>,
        Nayna <nayna@linux.vnet.ibm.com>,
        Prakhar Srivastava <prsriva02@gmail.com>,
        lkml <linux-kernel@vger.kernel.org>,
        linux-integrity@vger.kernel.org,
        inux-security-module@vger.kernel.org, zohar@linux.ibm.com,
        "Eric W. Biederman" <ebiederm@xmission.com>, vgoyal@redhat.com,
        Prakhar Srivastava <prsriva@microsoft.com>
Date:   Thu, 25 Apr 2019 16:18:58 -0700
In-Reply-To: <alpine.LRH.2.21.1904260833140.7315@namei.org>
References: <20190424001544.7188-1-prsriva02@gmail.com>
         <20190424001544.7188-2-prsriva02@gmail.com>
         <d38f32f8-7078-f205-ba11-9c4266ee40e8@linux.vnet.ibm.com>
         <4c313367-22dc-9532-54b5-cd3a79deb625@linux.microsoft.com>
         <CAADWXX8NC-PFJmuvQbNXn49CYjvyn-e0rtH_EoUfCvuJHTwHAQ@mail.gmail.com>
         <alpine.LRH.2.21.1904260833140.7315@namei.org>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 2019-04-26 at 08:34 +1000, James Morris wrote:
> On Thu, 25 Apr 2019, Linus Torvalds wrote:
> 
> > On Thu, Apr 25, 2019 at 10:19 AM prsriva <prsriva@linux.microsoft.c
> > om> wrote:
> > > 
> > > I will fix the comments and send out the patchset with a cover
> > > letter. Thankyou for pointing this out.
> > 
> > Please trim the emails you reply to rather than quoting everything.
> > 
> > But the real reason I'm reacting to this email is because it was
> > marked as spam, because your SMTP setup is incorrect, and you don't
> > go through the proper MS SMTP server. As a result, you don't get
> > the proper DKIM signature for verification of the microsoft.com
> > email address, and sane email clients will mark your emails as
> > spam.
> > 
> > Please fix.
> 
> It's the correct SMTP server for linux.microsoft.com.
> 
> linux.microsoft.com.	3600	IN	TXT	"v=spf1
> ip4:13.77.154.182 -all"
> linux.microsoft.com.	3600	IN	TXT	"v=DMARC
> 1;p=none;pct=100;rua=mailto:jamorris@microsoft.com"

That's not the correct location: DMARC records should be at the _dmarc.
subdomain.  without this you'll inherit the dmarc policy of
_dmarc.microsoft.com

> We don't have DKIM set up yet.

If you advertise DMARC, you're expected to have DKIM working for spam
purposes.  On the other hand, if you don't advertise DMARC, google will
probably still bin all your email as spam.

James