Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp12046yba; Thu, 25 Apr 2019 17:04:30 -0700 (PDT) X-Google-Smtp-Source: APXvYqyAml9xOivzrJ7wPH1kmoZ0o0iAO2RCDg6CQo5mtBySy//2ohucRES88kQgCt5DNHNkds/0 X-Received: by 2002:a63:8f49:: with SMTP id r9mr33666901pgn.306.1556237070091; Thu, 25 Apr 2019 17:04:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556237070; cv=none; d=google.com; s=arc-20160816; b=BWD2c6COMT0SN68muEfFQr+1o0pNjjiq86QoRaDuoM2ywIrx7A0kSHHZdDoy7HKV95 q+JDA2Ti1yZXR9fhSt46fOFeWQYdHB16Ffa1dB5Qzk1Xa1Xv/BuCZk9odqwmqaWYXpAh K5FOsTt7kZUOjdvR3WiEuKaL8UyPiUBQIBKv/1dgcaSSsnOqn7hbQNpcANvI3PxWOcWN WPL6No2+rGhkyMl1fuIPj5sVqhcTJyPLVkMDDYP3V6ULDMT6MeXEUzDMDSpoSGO+Rgr2 CigPP4kIeuz6VLdK581gy1fMPQODWId9MRmKozbBbgQisEs5TfhCp2nMimsOvrW6mCUM FDuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=RhHAMU00RFBMxfw+q8Gg348SmtL1L5zdVCD5+LMVRYE=; b=f6bLVR/vHZtxMAcNJUVSs8GTGem47ySJAwX4buTQhy5pvsVARTmpK2+xLn5VPPO7wX cWjVblt2foFFDBAyMgShB8gkZvpH0nQ8nAmbhjjJ+Tjsbpgo3nQA/wo+niDgska5uySE aJ1s1ksubqLbpWLgQZnzMpvh/GxHMcjwcur2O6yD5tJbWXkVLmwwUXdYaY1Z8a3cORLV JGnAasZmyhhaQtwI29QAl57NHSAf1Xw6cq3q728lWVL7eLtP48zDE9JMSKIkIvYu1r+A ZIKCOhmH227eMoudfJbH1+POoslP3xNA8SktlTR8T72M+dx+zoypmu5fD79sdib9GFyG zDJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=PhbMhyQE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l86si24679755pfb.182.2019.04.25.17.04.14; Thu, 25 Apr 2019 17:04:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=PhbMhyQE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728265AbfDYTnk (ORCPT + 99 others); Thu, 25 Apr 2019 15:43:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:38016 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725937AbfDYTnk (ORCPT ); Thu, 25 Apr 2019 15:43:40 -0400 Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net [24.9.64.241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 039D0205ED; Thu, 25 Apr 2019 19:43:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556221420; bh=YzEBQMIXdQu3DmEeibuqftlk9xUGTtYM+2sCQw5SGbI=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=PhbMhyQETta+z0lnUb7wfM0HykaostdPWl2qt2kBfqAkAPu6E4tN0FWth7D+nCCEb 0k1O44ObHcvZXMf7QOeGH8vPo+RiE8Ezv+cbDZp/P+FBEG0HWsES+j4Tf7EEbU4hEr LzbgAMFhV5P6NFmFFNSvFCWzghFoKE822Wmyy8qE= Subject: Re: [PATCH] selftests : netfilter: Wrote a error and exit code for a command which needed veth kernel module. To: Jeffrin Thalakkottoor , pablo@netfilter.org Cc: Florian Westphal , linu-kselftest@vger.kernel.org, lkml , shuah References: <20190405163126.7278-1-jeffrin@rajagiritech.edu.in> <20190405164746.pfc6wxj4nrynjma4@breakpoint.cc> From: shuah Message-ID: Date: Thu, 25 Apr 2019 13:43:39 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/13/19 6:39 AM, Jeffrin Thalakkottoor wrote: > Hello Shuah, > > did you get the mail related stuff below ? > Yes I saw this patch. > On Fri, Apr 5, 2019 at 10:17 PM Florian Westphal wrote: >> >> Jeffrin Jose T wrote: >>> A test for the basic NAT functionality uses ip command which >>> needs veth device.There is a condition where the kernel support >>> for veth is not compiled into the kernel and the test script >>> breaks.This patch contains code for reasonable error display >>> and correct code exit. >> >> Looks good to me, thanks for following up on this. >> >> Acked-by: Florian Westphal > > > Pablo, Would you like me to take this patch through ksleftest tree? If you want to take this through netfilter tree: Acked-by: Shuah Khan thanks, -- Shuah