Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1556201031-3676-1-git-send-email-hofrat@osadl.org>
In-Reply-To: <1556201031-3676-1-git-send-email-hofrat@osadl.org>
From:   Rob Clark <robdclark@gmail.com>
Date:   Thu, 25 Apr 2019 17:02:14 -0700
Message-ID: <CAF6AEGu80YyDeGkShhrSSysmiHkNMWTL6H_uC1UJKzy88mwyGA@mail.gmail.com>
Subject: Re: [PATCH] drm/msm: check for equals 0 only
To:     Nicholas Mc Guire <hofrat@osadl.org>
Cc:     Sean Paul <sean@poorly.run>, David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Abhinav Kumar <abhinavk@codeaurora.org>,
        Jordan Crouse <jcrouse@codeaurora.org>,
        Archit Taneja <architt@codeaurora.org>,
        Daniel Mack <daniel@zonque.org>,
        Sibi Sankar <sibis@codeaurora.org>,
        Chandan Uddaraju <chandanu@codeaurora.org>,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        freedreno <freedreno@lists.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Apr 25, 2019 at 7:09 AM Nicholas Mc Guire <hofrat@osadl.org> wrote:
>
> wait_for_completion_timeout() returns 0 on timeout and aleast 1 otherwise
> so checking for < makes no sense here.
>
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> ---
>
> Problem located with an experimental coccinelle script
>
> While this check does no harm in this form - it should be fixed anyway
> to comply with the API see: kernel/sched/completion.c
>
> Also noticed that get_maintainer.pl will not list linux-kernel@vger.kernel.org
> when run on drivers/gpu/drm/msm/dsi/dsi_host.c - is that intentional ?

Thanks, I'll pull this in for -fixes

as far as get_maintainer.pl.. I'm not entirely sure.. we don't list
linux-kernel@vger.kernel.org explicitly, but neither do a lot of the
other driver entries.  Possibly this is a oversight in the MAINTAINERS
entry?  Either way, I guess I'd say that it isn't intentional.

BR,
-R

>
> Patch was compile-tested with: qcom_defconfig (implies DRM_MSM_DSI=y)
>
> Patch is against v5.1-rc6 (localversion-next is next-20190424)
>
>  drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c
> index 610183d..dc16067 100644
> --- a/drivers/gpu/drm/msm/dsi/dsi_host.c
> +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
> @@ -1049,7 +1049,7 @@ static void dsi_wait4video_done(struct msm_dsi_host *msm_host)
>         ret = wait_for_completion_timeout(&msm_host->video_comp,
>                         msecs_to_jiffies(70));
>
> -       if (ret <= 0)
> +       if (ret == 0)
>                 DRM_DEV_ERROR(dev, "wait for video done timed out\n");
>
>         dsi_intr_ctrl(msm_host, DSI_IRQ_MASK_VIDEO_DONE, 0);
> --
> 2.1.4
>