Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp286910yba; Thu, 25 Apr 2019 23:23:31 -0700 (PDT) X-Google-Smtp-Source: APXvYqxxC9fraloTw9yniIWx+lalKTuBKrsvxPrtxj53+23cF2tNxxh/2zqE/1/Ag6bR6Anns+w4 X-Received: by 2002:aa7:82cb:: with SMTP id f11mr46490881pfn.0.1556259811306; Thu, 25 Apr 2019 23:23:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556259811; cv=none; d=google.com; s=arc-20160816; b=OzfyjGOP3AX5yiyZecq6dxdH7vHHKUjnoYwSE5eZrCKAIYLO/4j4Wt3KSsPOhTXcuv jl3/wKadw5ghuabkRjLsG0VMZNgDkFxZZ2rADQDG3yKLnXLbM/mrzhSNbq9fGwv00MNE 7F8sQ9HSMfv9ZVzR8p9EAgebn46bSddewK1R8shVfDgzCPe8zGiffM4mvR71aD2jhAZ+ gBTtQtzoZ3xkr9sM4otmqNuPf1eKVpL9ImCeVD1Oo7k0aV33ku/Apsnwg47r0NanjW6K PfQPrfhMbNB6gLSeqrbw+DRM0+mEuegkLwKHKocEweXtgUXhcZDmoia9UtDZlOJFx7DX l2wA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:cc:to:subject:from:references :in-reply-to:message-id:dkim-signature; bh=TJnDwm+UkR7ne5GWLWogSs2op89RjaK7n1C4W7S+zpg=; b=HMsPD+WCiIUVPBXtbMh5TF+z0FTx40yId/+dISDawOtHgfSaYf+tq2UXhm4sSSdv/X SYdAm525Dwiv8t2HntLJKNmNXsdt4OcXcQv7C54jjdcXe9KfhuGPVdV0tMFzsGmU2MUf XNqhDhI+rzSBgnHCJEQh1xEwzKfCXKRq0ZvGtGKRjC+LO/jQUVQLEjQTSUCxLUfhEVHf UYY1CwvNZHLeiCDgoTrEai8+xpGPWW16ZMO+oMwjNibRwpkMPlHYCmj6zB4LHyqs5b8N e0xmpjMEHtm1Su7dNq8xwVPy/jQUsWZS+eMog1YUZj6K264QQiBpDbjyNeGQwnHZPdci TAiA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@c-s.fr header.s=mail header.b=Jg6FRVjA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s14si22955049pgs.343.2019.04.25.23.23.15; Thu, 25 Apr 2019 23:23:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@c-s.fr header.s=mail header.b=Jg6FRVjA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726622AbfDZF7l (ORCPT + 99 others); Fri, 26 Apr 2019 01:59:41 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:38531 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725901AbfDZF7j (ORCPT ); Fri, 26 Apr 2019 01:59:39 -0400 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 44r3Kh5zjMz9v1v8; Fri, 26 Apr 2019 07:59:36 +0200 (CEST) Authentication-Results: localhost; dkim=pass reason="1024-bit key; insecure key" header.d=c-s.fr header.i=@c-s.fr header.b=Jg6FRVjA; dkim-adsp=pass; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id 3BihIFiSZerr; Fri, 26 Apr 2019 07:59:36 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 44r3Kh4xH4z9v1tj; Fri, 26 Apr 2019 07:59:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c-s.fr; s=mail; t=1556258376; bh=TJnDwm+UkR7ne5GWLWogSs2op89RjaK7n1C4W7S+zpg=; h=In-Reply-To:References:From:Subject:To:Cc:Date:From; b=Jg6FRVjA+kqV+42o266wlWtnHHlNc8UEcJCV3d9S4RkZuOOMkBfgQxPQbWbKSNPZp BN60HIdv8DvUTsJVmspfPAtOxWXGYS8OIIvL6pp/JxLVKY7skV/UL5X06Flfihff6R n8G3DdtAiUZ8HpMLP+QATiiJNNUG/W6/aGA1VMJY= Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 8F3D38B807; Fri, 26 Apr 2019 07:59:37 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id 8sMxq4GO65cU; Fri, 26 Apr 2019 07:59:37 +0200 (CEST) Received: from po16846vm.idsi0.si.c-s.fr (po15451.idsi0.si.c-s.fr [172.25.231.6]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 73E6D8B74C; Fri, 26 Apr 2019 07:59:37 +0200 (CEST) Received: by po16846vm.idsi0.si.c-s.fr (Postfix, from userid 0) id 68B1866278; Fri, 26 Apr 2019 05:59:37 +0000 (UTC) Message-Id: In-Reply-To: References: From: Christophe Leroy Subject: [PATCH v2 02/17] powerpc/mm: don't BUG in add_huge_page_size() To: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , aneesh.kumar@linux.ibm.com Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Date: Fri, 26 Apr 2019 05:59:37 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use VM_BUG_ON() instead of BUG_ON(), as those BUG_ON() are not there to catch runtime errors but to catch errors during development cycle only. Signed-off-by: Christophe Leroy --- arch/powerpc/mm/hugetlbpage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/mm/hugetlbpage.c b/arch/powerpc/mm/hugetlbpage.c index 9e732bb2c84a..6b9b6d747df3 100644 --- a/arch/powerpc/mm/hugetlbpage.c +++ b/arch/powerpc/mm/hugetlbpage.c @@ -634,7 +634,7 @@ static int __init add_huge_page_size(unsigned long long size) } #endif - BUG_ON(mmu_psize_defs[mmu_psize].shift != shift); + VM_BUG_ON(mmu_psize_defs[mmu_psize].shift != shift); /* Return if huge page size has already been setup */ if (size_to_hstate(size)) -- 2.13.3