Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190424101934.51535-1-duyuyang@gmail.com> <20190424101934.51535-23-duyuyang@gmail.com>
 <20190425195212.GW12232@hirez.programming.kicks-ass.net>
In-Reply-To: <20190425195212.GW12232@hirez.programming.kicks-ass.net>
From:   Yuyang Du <duyuyang@gmail.com>
Date:   Fri, 26 Apr 2019 14:47:52 +0800
Message-ID: <CAHttsrYgxQ6zB+V2gVgPZT1y9n9X-cC+6HYrhyL++eaSknJoRg@mail.gmail.com>
Subject: Re: [PATCH 22/28] locking/lockdep: Adjust new bit cases in mark_lock
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     will.deacon@arm.com, Ingo Molnar <mingo@kernel.org>,
        Bart Van Assche <bvanassche@acm.org>, ming.lei@redhat.com,
        Frederic Weisbecker <frederic@kernel.org>, tglx@linutronix.de,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Thanks for review.

On Fri, 26 Apr 2019 at 03:52, Peter Zijlstra <peterz@infradead.org> wrote:
> > +     if (new_bit >= LOCK_USAGE_STATES) {
> > +             WARN_ON(1);
>
> Does that want to be DEBUG_LOCKS_WARN_ON() ?

Indeed, it was.