Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp306478yba; Thu, 25 Apr 2019 23:51:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqzMXU0zDT/FnMrhU5JyALHTsGk5d6XRK8MkPFiyzut3GMffSuPM9zsFoalG6ED6eV66B5wE X-Received: by 2002:a17:902:b589:: with SMTP id a9mr19767018pls.66.1556261487808; Thu, 25 Apr 2019 23:51:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556261487; cv=none; d=google.com; s=arc-20160816; b=cq8Jvk3nXvcA7z6B8pPVN2np1T0t3ixQKRV/R5GGoZIE8AY/Hr+TSzoQE5o28X/2An ++Ls+bMOnPVp6C74zgOn2TX5IUs4JfdWHCJR6//1yyyTbr7CwYvebNAB35cUlxKbjhen Qpa8qtVcBv/exHCRDQiSu4sokd7K7gKZdezJj+eCGx+f/Fx1W8F+3TGlJIKBEmDQJ5uM +LTDnXtLUYZwbo3qG9SYBrMDq3hwFQt+a4UVEpcgRtW63XUhWk5oPm4HoCHy8CBYlv2k DvzyQofywMul3kGm4AtZSWlFeCIp5riuSOR/MmQ3oszkU+J+VCdoEFm2MA9tlEa0xKq4 7LbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=SuYwYgDlBbc3CltRwXqXxO+HoBkiBPtieGRYvV2Q7AE=; b=b2H/9j8yY45JWmVtLVQKWQ7TGAf7L8yDtqyb1cXxKIek3jsnUaJUWWpvHXVugMS0rX o4CNzaJObQbkH49ISdHqNkOmu7Uus7ojqhsWHAleQy5vG7B2MTCN06ySLXmLWc1IMmMb PuhqB8ycCuvUioA/Jc0Lu8+DGars+hafoImohO+uN9e02NMylLC666e6+dfZ4yRbNnNF z5CCpE6c5g88cuPmp3L3Ndh/9ClMFlfmtZ4KIe5D7EzN+eHqwxz4aZombAynGr3C9OwO jRwhChE0MPrnPAY0+sohP2B5Nnik9gdjdIR6dbw4E3YOnE9EVEEGdreMKn/GMJ1QbPWJ JuQQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g90si25285089plb.140.2019.04.25.23.51.12; Thu, 25 Apr 2019 23:51:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726049AbfDZGru (ORCPT + 99 others); Fri, 26 Apr 2019 02:47:50 -0400 Received: from Mailgw01.mediatek.com ([1.203.163.78]:30606 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725901AbfDZGru (ORCPT ); Fri, 26 Apr 2019 02:47:50 -0400 X-UUID: 2b670c16918c4daa9fff884702ae7fc9-20190426 X-UUID: 2b670c16918c4daa9fff884702ae7fc9-20190426 Received: from mtkcas34.mediatek.inc [(172.27.4.253)] by mailgw01.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 2088178522; Fri, 26 Apr 2019 14:47:40 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by MTKMBS31DR.mediatek.inc (172.27.6.102) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 26 Apr 2019 14:47:38 +0800 Received: from localhost.localdomain (10.17.3.153) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 26 Apr 2019 14:47:37 +0800 From: Chunfeng Yun To: Rob Herring , Greg Kroah-Hartman , Heikki Krogerus CC: Mark Rutland , Chunfeng Yun , Matthias Brugger , Adam Thomson , Li Jun , Badhri Jagan Sridharan , Hans de Goede , Andy Shevchenko , Min Guo , , , , , , Biju Das , Linus Walleij Subject: [PATCH v4 4/6] usb: roles: add API to get usb_role_switch by node Date: Fri, 26 Apr 2019 14:47:15 +0800 Message-ID: <1556261237-13823-5-git-send-email-chunfeng.yun@mediatek.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1556261237-13823-1-git-send-email-chunfeng.yun@mediatek.com> References: <1556261237-13823-1-git-send-email-chunfeng.yun@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add fwnode_usb_role_switch_get() to make easier to get usb_role_switch by fwnode which register it. It's useful when there is not device_connection registered between two drivers and only knows the fwnode which register usb_role_switch. Signed-off-by: Chunfeng Yun --- v4 changes: 1. use switch_fwnode_match() to find fwnode suggested by Heikki 2. this patch now depends on [1] [1] [v6,08/13] usb: roles: Introduce stubs for the exiting functions in role.h https://patchwork.kernel.org/patch/10909971/ v3 changes: 1. use fwnodes instead of node suggested by Andy 2. rebuild the API suggested by Heikki v2 no changes --- drivers/usb/roles/class.c | 25 +++++++++++++++++++++++++ include/linux/usb/role.h | 8 ++++++++ 2 files changed, 33 insertions(+) diff --git a/drivers/usb/roles/class.c b/drivers/usb/roles/class.c index f45d8df5cfb8..994fcb979795 100644 --- a/drivers/usb/roles/class.c +++ b/drivers/usb/roles/class.c @@ -12,6 +12,7 @@ #include #include #include +#include #include static struct class *role_class; @@ -135,6 +136,30 @@ struct usb_role_switch *usb_role_switch_get(struct device *dev) } EXPORT_SYMBOL_GPL(usb_role_switch_get); +/** + * fwnode_usb_role_switch_get - Find USB role switch by it's parent fwnode + * @fwnode: The fwnode that register USB role switch + * + * Finds and returns role switch registered by @fwnode. The reference count + * for the found switch is incremented. + */ +struct usb_role_switch * +fwnode_usb_role_switch_get(struct fwnode_handle *fwnode) +{ + struct usb_role_switch *sw; + struct device *dev; + + dev = class_find_device(role_class, NULL, fwnode, switch_fwnode_match); + if (!dev) + return ERR_PTR(-EPROBE_DEFER); + + sw = to_role_switch(dev); + WARN_ON(!try_module_get(sw->dev.parent->driver->owner)); + + return sw; +} +EXPORT_SYMBOL_GPL(fwnode_usb_role_switch_get); + /** * usb_role_switch_put - Release handle to a switch * @sw: USB Role Switch diff --git a/include/linux/usb/role.h b/include/linux/usb/role.h index da2b9641b877..35d460f9ec40 100644 --- a/include/linux/usb/role.h +++ b/include/linux/usb/role.h @@ -48,6 +48,8 @@ int usb_role_switch_set_role(struct usb_role_switch *sw, enum usb_role role); enum usb_role usb_role_switch_get_role(struct usb_role_switch *sw); struct usb_role_switch *usb_role_switch_get(struct device *dev); void usb_role_switch_put(struct usb_role_switch *sw); +struct usb_role_switch * +fwnode_usb_role_switch_get(struct fwnode_handle *fwnode); struct usb_role_switch * usb_role_switch_register(struct device *parent, @@ -72,6 +74,12 @@ static inline struct usb_role_switch *usb_role_switch_get(struct device *dev) static inline void usb_role_switch_put(struct usb_role_switch *sw) { } +static inline struct usb_role_switch * +fwnode_usb_role_switch_get(struct fwnode_handle *fwnode) +{ + return ERR_PTR(-ENODEV); +} + static inline struct usb_role_switch * usb_role_switch_register(struct device *parent, const struct usb_role_switch_desc *desc) -- 2.21.0