Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp352757yba; Fri, 26 Apr 2019 00:55:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqx6xeVx9SO5E6tO63EjSb0Qwc/ljlM9Ro2pEE/IFc/x6cNE3DCUPS2X+HBFKbTjLX+nUr1y X-Received: by 2002:a63:fd58:: with SMTP id m24mr18518158pgj.298.1556265308502; Fri, 26 Apr 2019 00:55:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556265308; cv=none; d=google.com; s=arc-20160816; b=0whp9brnxLXo8M9SNGEQ8+Titg/LEC/4vN8e6xtO4XwgWkWtNklLs3+KF9OmrkxNaP 8Kl7hzhoV55mJ9F3hsVS86IUP9ROs6bKAr3Byz+Mh1k3Uh+33K4hj8CKKdibJ2Y9dTne vO7C2KIIMCnWU1ZxWtedbo+CVyPzS5RkugLP+T6XMEx+gDxlxY86OIZawyxdw++TUJGR ASkP7M8HYi4N30i2yJ3XPOTeXBSsYlOnChgbXGvZEj7QoTYuXaYfytD9rByhNbbOgpvw e3SVwWatbw5oDEuelf6KjLl9MY9A51NSFFR+phREl4Znz3OHPB+Huyvj6UVOyjcwe0t0 bw/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=uAvx3d3/cKphohPsiu9DZOfBv9cjOPg+wsnLLb2OzZY=; b=gy2Eiz0mU0k0nipn56Hg8R3+ZHE3vqMbFQZe3VvAbi9QkDWg9hLm+HzMw7NskP3lGU QNfDTv/MosyUnWkgy6QlPNEujbIH5ICkIIe/8Cy0ssMj3QxfyHZGSn28HpdU9Zc7M5zK dmG/9cJGiztOQR6CrTsufDNF+HReQQUb0YOI/KJeMHKksv1ebpMwnE3ZK/zkqj64rV2S AVMxBhYvdLGWbJTD15U30o5fkN5eaZoF0VRQbRyBmd75/0+izofjMyvm7U7j1Q7ti75q TMsP/a3dTbaAQXvGwyUzAle6CZ119qZNhQBchYVakQJOlmoLMpkI2OKWepvVsPuCtc2s P1CA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=zCHgoeMm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a3si24561947pfc.276.2019.04.26.00.54.52; Fri, 26 Apr 2019 00:55:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=zCHgoeMm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725959AbfDZHyC (ORCPT + 99 others); Fri, 26 Apr 2019 03:54:02 -0400 Received: from merlin.infradead.org ([205.233.59.134]:59428 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725912AbfDZHyB (ORCPT ); Fri, 26 Apr 2019 03:54:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=uAvx3d3/cKphohPsiu9DZOfBv9cjOPg+wsnLLb2OzZY=; b=zCHgoeMmJS8YKiw61Ctj0c29e utnZMwCXhDat9KusX/Yd1pmweJ4Q9mXttDRpSMT04TKRYMjpKLUb9F3gWZlVqnYsfhAgfzp0RPhrE X0heD6EeRs7FWLeWRk4IY5TBf3pbn2iZd7tBNxPlypHhLq8L0Ilb88DQZsigKYbJNfvMbdkBN4OF/ OX/FhNPHdQn8eZF5AjJj5nrWuPqOtpto1xMzWuS7qHxTlBHtqlkyS38x/xRX5eHTwp+iR59WpUplR wVOOSrHu9egBC7rmH7T+mUaLHyCzlaRnKMRkwXHnZiIczA9BPBTzfX89mU+sD04qmqjVeIWirz4Nw GLuaocetg==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1hJvg8-0004bF-MI; Fri, 26 Apr 2019 07:53:53 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 0281629D1A322; Fri, 26 Apr 2019 09:53:49 +0200 (CEST) Date: Fri, 26 Apr 2019 09:53:49 +0200 From: Peter Zijlstra To: Nadav Amit Cc: Ingo Molnar , Borislav Petkov , Andy Lutomirski , Ingo Molnar , Thomas Gleixner , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , Dave Hansen Subject: Re: [PATCH v2] x86/mm/tlb: Remove flush_tlb_info from the stack Message-ID: <20190426075349.GA4038@hirez.programming.kicks-ass.net> References: <20190425180828.24959-1-namit@vmware.com> <20190425192930.GA91578@gmail.com> <82E44F4A-E52D-4666-95B5-C6248A14A442@vmware.com> <20190425194837.GB58719@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 25, 2019 at 09:20:24PM +0000, Nadav Amit wrote: > > I think that's a bug and PeterZ is fixing those. > > This would be quite surprising. I need to get back to that percpu series .... :/ > Even atomic_dec() does not imply a compilers > barrier. I think I should leave it as is for now, and let Peter change it > later if he decides to do so. Let me know if you disagree. https://lkml.kernel.org/r/20190424124421.808471451@infradead.org