Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190425133435.56065-1-anup.patel@wdc.com> <9a8be7ef-e62e-2a93-9170-e3dc70dfb25f@wdc.com>
 <20190426062133.GA28529@infradead.org>
In-Reply-To: <20190426062133.GA28529@infradead.org>
From:   Anup Patel <anup@brainfault.org>
Date:   Fri, 26 Apr 2019 14:12:34 +0530
Message-ID: <CAAhSdy1nVFCwiP6vyy9i2f+S2WxLodmdwpwUKZUHYz15YfR64g@mail.gmail.com>
Subject: Re: [PATCH] tty: Don't force RISCV SBI console as preferred console
To:     Christoph Hellwig <hch@infradead.org>
Cc:     Atish Patra <atish.patra@wdc.com>,
        Palmer Dabbelt <palmer@sifive.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Anup Patel <Anup.Patel@wdc.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>,
        Albert Ou <aou@eecs.berkeley.edu>,
        Jiri Slaby <jslaby@suse.com>,
        "linux-riscv@lists.infradead.org" <linux-riscv@lists.infradead.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Apr 26, 2019 at 11:51 AM Christoph Hellwig <hch@infradead.org> wrote:
>
> On Thu, Apr 25, 2019 at 09:41:21PM -0700, Atish Patra wrote:
> > Do we even need HVC_SBI console to be enabled by default? Disabling
> > CONFIG_HVC_RISCV_SBI seems to be fine while running in QEMU.
> >
> > If we don't need it, I suggest we should remove the config option from
> > defconfig in addition to this patch.
>
> I think the whole concept of the SBI console is a little dangerous.
> It means that for one piece of physical hardware (usually the uart)
> we have two entiries (the M-mode firmware and the OS) in control,
> which tends to rarely end well.

I think the SBI console is only useful for early SOC bringup and early
SOC debugging when most drivers are not available in upstream
kernel. It cannot (and should not) be used in production deployments.

Regards,
Anup