Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp441007yba; Fri, 26 Apr 2019 02:51:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqzSREHbyUac4r2VNKxLALgZE0VrEL6/Kgs7KiZxuO5N3X+DuhchA76v2iQyE0CdzV7kL3x9 X-Received: by 2002:a62:2587:: with SMTP id l129mr7175020pfl.151.1556272287086; Fri, 26 Apr 2019 02:51:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556272287; cv=none; d=google.com; s=arc-20160816; b=ir9azTTSg14nL3vN1mYngBnf8tpqin54NUmu6qcMVPRIrxaMb0dRNNaWi234OLr7Vn KBOtd2F6UcMoWOcXwFlZ12OHTB+QeYPO+X05q12ikaJxX2l83AAGHCXlLBwq6asJBzCy 0014dQcsscMabJN2MBe5w2SgdpSyAHsG67P8OuWalBopRBzHYNC3hZm6NC/hQ8cassCE D0d6cmhJJIp/A4afbw3EBiuSDH+Wj1Eh1M0BvUle/0Ol7dzhVnaiBT8RpjAjvdlPaU8l 2y3F36qjIhaHufgQyDjNAga0jSyZrAmfikrTLJlpB5+hg0+LylGEqe3FCYsPjnGuN1zM GEmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:in-reply-to:subject:cc:to :from:dkim-signature; bh=xyrB61ZcsA7w8QQMNTNsT4INetcMTolXtVi1jB7Rq/8=; b=AD0g/rtSJ8dObaRYwKa0QbTZFOKhIQL5fVuECFNNDuhP8f+l4ebRZJLyyxYfYa+iNm m1aTLvRxeYGWS5vYKu5Wg8VZeBwU0u3ZQStK1vbQXmT2MPFwsbN+SEdKTFrpXzuXA/FU FJyoFr4ohQsKBMhg88m3IK7xGoNz0RGRWfTTmR4JnmtYL0ZY1B5yAavk0DdzIe2Ibx5W B0tr6C0HvaCdn39KhiHOuKrS18t1DPS2spYRgD3AUEgPZd+xdOonJkf75hbk8Sdu2+6B ar55VoAZjmofGznWzhC41yiMnpGEBK9U0HzSn700QYpMIafVCw8Kw/0vewT7FKJ/tMJG ktGQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=k6Vd2yHr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 33si26153047plt.161.2019.04.26.02.51.12; Fri, 26 Apr 2019 02:51:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=k6Vd2yHr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727239AbfDZJo0 (ORCPT + 99 others); Fri, 26 Apr 2019 05:44:26 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:52458 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726481AbfDZJoX (ORCPT ); Fri, 26 Apr 2019 05:44:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=xyrB61ZcsA7w8QQMNTNsT4INetcMTolXtVi1jB7Rq/8=; b=k6Vd2yHrQ/UY 83AHrzI7hSomFK8Cbe0+SLm+MhLcWg9GSio2oJ9RtljxmBxSjmlbjsxnb97vYM+8IvMzS3SN5othj VatrRL7+y69fJlUXuoYbsbjymv3o8tcikzTDM8ocf47GvX+RMp5qsblTO6D+4HSZfMIrTlKYwjiQm Tnu04=; Received: from [37.205.61.202] (helo=finisterre.ee.mobilebroadband) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hJxP2-0003Nd-7X; Fri, 26 Apr 2019 09:44:20 +0000 Received: by finisterre.ee.mobilebroadband (Postfix, from userid 1000) id 462ED441D3C; Fri, 26 Apr 2019 10:44:19 +0100 (BST) From: Mark Brown To: Jorge Ramirez-Ortiz Cc: broonie@kernel.org, jorge.ramirez-ortiz@linaro.org, khasim.mohammed@linaro.org, lgirdwood@gmail.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Brown Subject: Applied "regulator: core: do not report EPROBE_DEFER as error but as debug" to the regulator tree In-Reply-To: <20190417192443.6501-1-jorge.ramirez-ortiz@linaro.org> X-Patchwork-Hint: ignore Message-Id: <20190426094419.462ED441D3C@finisterre.ee.mobilebroadband> Date: Fri, 26 Apr 2019 10:44:19 +0100 (BST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch regulator: core: do not report EPROBE_DEFER as error but as debug has been applied to the regulator tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-5.2 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From b9816363c0e82f4cd8f9be8153fbc5b81b22911c Mon Sep 17 00:00:00 2001 From: Jorge Ramirez-Ortiz Date: Wed, 17 Apr 2019 21:24:43 +0200 Subject: [PATCH] regulator: core: do not report EPROBE_DEFER as error but as debug Temporary failures to get a regulator (EPROBE_DEFER) should be logged as debug information instead of errors. Signed-off-by: Jorge Ramirez-Ortiz Signed-off-by: Mark Brown --- drivers/regulator/core.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index 5a9ebcf7fe7a..08ccabe07fe3 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -4345,8 +4345,6 @@ int regulator_bulk_get(struct device *dev, int num_consumers, consumers[i].supply); if (IS_ERR(consumers[i].consumer)) { ret = PTR_ERR(consumers[i].consumer); - dev_err(dev, "Failed to get supply '%s': %d\n", - consumers[i].supply, ret); consumers[i].consumer = NULL; goto err; } @@ -4355,6 +4353,13 @@ int regulator_bulk_get(struct device *dev, int num_consumers, return 0; err: + if (ret != -EPROBE_DEFER) + dev_err(dev, "Failed to get supply '%s': %d\n", + consumers[i].supply, ret); + else + dev_dbg(dev, "Failed to get supply '%s', deferring\n", + consumers[i].supply); + while (--i >= 0) regulator_put(consumers[i].consumer); -- 2.20.1