Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp555364yba; Fri, 26 Apr 2019 05:03:24 -0700 (PDT) X-Google-Smtp-Source: APXvYqzmbjyw8fzuCydUw1CXw5dI9Y2dM4yZ5V/11sVvVhE0xEIq7IxMB5k8Gh7cXEkCoSzU2Jvz X-Received: by 2002:a17:902:442:: with SMTP id 60mr46318845ple.107.1556280204346; Fri, 26 Apr 2019 05:03:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556280204; cv=none; d=google.com; s=arc-20160816; b=x7mTmihFEFh0tWMxzGW2ERUOtRS/8pey1DAWmJgu3ufIUyASvuvM2a/qRwvMG07BAj BjVeHN84tlBqSAjxqZMTtiP7YMxUlCfEJ6PLC97rxg3JWab8fqNLbGdieoBqMGgig4YE +i4CrjdNGQ/ICwjfxvzF/nvUjNr2FtFgeTN0TkkQ9GjdpLbOyhXLCm6NBsgwKoc/oHuS uWwVeyFzr00PXNdmIAvQis/pLjIRej9H3FlVfOklvxxB1WGKkbSw4tBAtyX3EwmCeGOh lCsDZZVOzHCO5244MUxdCU+yyqlPblfqwVIs0ORiJeHmaGqIF30VvROyigZSEY3S2L2J Pxow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=7Y9FBw6nwyF+GVdCM4ZsGeTu2UDsaWEIJ+VKjwlMGII=; b=mi0Kp9hrYICZ60h3dRwKPPll5aGuoAjFuwuvPS8CZRkRcVsH5SFfIa7i0gdgqPQAQr +J3S4PwfUgPeS//Ey2RMgS5lwiQq9BhKtxFvFfdKUwiNHwGclsaQWome4lNJ9tW/R3j4 vUoFGST5DEVLh6zTsIcbiXIoEx3RX26zM+4hyA/o1ExlYghvEOZcWEX0LfFtWz+iSP9+ 22xmWw9KbqkUz7N4ssCbyGa6dnUV7e+lffRyDx1hBkAlCPGfr1X2pGUIbncuMlc6qBHs fVbAtjw9KE4Gcp0zqCfnA4x+PkHUvUVjCq+df1K1sVqXHc++VSE4z2rTYh4JSLPYWcEG jNbg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=1FJxFm9y; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u5si25455212pgl.36.2019.04.26.05.03.07; Fri, 26 Apr 2019 05:03:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=1FJxFm9y; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726152AbfDZMBz (ORCPT + 99 others); Fri, 26 Apr 2019 08:01:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:49942 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726048AbfDZMBy (ORCPT ); Fri, 26 Apr 2019 08:01:54 -0400 Received: from localhost (unknown [171.76.113.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 469ED206C1; Fri, 26 Apr 2019 12:01:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556280114; bh=Vowjtrv0OJqv16TygegnL2eNyyqR0noN1UiGX25yQ5M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1FJxFm9yyGkW7/V4pU3/CJBWNf1kfnlus8LFDwz7yzcUTAO0hM6LSqYL4QLkYNkhb /uVaRnSnzFrdalkqxNTV2rBeUpKeeC1Y/tjEgt+3Py+viXjnqub3wkGFgrKSWkFJaL Gr/tGF2AVfx21Bal8t39J8Xe16y8NzM4cWsS76L0= Date: Fri, 26 Apr 2019 17:31:48 +0530 From: Vinod Koul To: Dmitry Osipenko Cc: Laxman Dewangan , Thierry Reding , Jonathan Hunter , dmaengine@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] dmaengine: tegra: Use relaxed versions of readl/writel Message-ID: <20190426120148.GB28103@vkoul-mobl> References: <20190424231708.21219-1-digetx@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190424231708.21219-1-digetx@gmail.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25-04-19, 02:17, Dmitry Osipenko wrote: > The readl/writel functions are inserting memory barrier in order to > ensure that memory stores are completed. On Tegra20 and Tegra30 this > results in L2 cache syncing which isn't a cheapest operation. The > tegra20-apb-dma driver doesn't need to synchronize generic memory > accesses, hence use the relaxed versions of the functions. Subsystem name is **dmaengine** not dma! Please fix that -- ~Vinod