Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190118100828.GA5143@kroah.com> <20190118112028.GG3271@phenom.ffwll.local>
 <20190426004229.GC21072@darkstar.musicnaut.iki.fi>
In-Reply-To: <20190426004229.GC21072@darkstar.musicnaut.iki.fi>
From:   Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Fri, 26 Apr 2019 14:14:08 +0200
Message-ID: <CAKMK7uE72n-jSF1ZWTidMAUJUKMfqcVi-4zQd7hRrKTp-Skjqg@mail.gmail.com>
Subject: Re: [PATCH] staging: xgifb: delete the driver
To:     Aaro Koskinen <aaro.koskinen@iki.fi>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Arnaud Patard <arnaud.patard@rtp-net.org>,
        Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
        driverdevel <devel@driverdev.osuosl.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        Thomas Zimmermann <tzimmermann@suse.de>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Apr 26, 2019 at 2:42 AM Aaro Koskinen <aaro.koskinen@iki.fi> wrote:
> On Fri, Jan 18, 2019 at 12:20:28PM +0100, Daniel Vetter wrote:
> > On Fri, Jan 18, 2019 at 11:08:28AM +0100, Greg Kroah-Hartman wrote:
> > > There has not been any real work done on cleaning this driver up and
> > > getting it out of the staging tree in years.  Also, no new fb drivers
> > > are being added to the tree, so it should be converted into a drm driver
> > > as well.
> > >
> > > Due to the lack of interest in this codebase, just drop it.
> > >
> > > Cc: Arnaud Patard <arnaud.patard@rtp-net.org>
> > > Cc: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
> > > Reported-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >
> > Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> Because of this I just lost fb/display on two of my computers...
>
> So I guess to reintroduce the support for this HW I need to write a new
> DRM driver and no staging work anymore. Which of the current DRM drivers
> would be best to be used as a template/example for a new driver?

For a simple driver pick any of the recently merged ones using the
drm_simple_display_pipe helpers, those will get rid of all the
boilerplate for you. If you have vram, you might need the in-flight
vram helpers that currently are worked on by Thomas Zimmermann (they
refactor simple vram handling from about 5 drivers into a new helper,
with the goal to make porting fbdev drivers even easier).
-Daniel


--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch