Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp699676yba; Fri, 26 Apr 2019 07:22:29 -0700 (PDT) X-Google-Smtp-Source: APXvYqzYqc0RIES5VvkxOVVRAdYQxjfDbGSzMpizUxqeLCKNa26PF/RezMWztkNi49yF6Rie6v7t X-Received: by 2002:a17:902:8ecc:: with SMTP id x12mr46574538plo.0.1556288549037; Fri, 26 Apr 2019 07:22:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556288549; cv=none; d=google.com; s=arc-20160816; b=l8i6OOLneceK1ii5++k+mtr0w7N0DOuMca2nepN55f+aiFe809CoRKAzY2S+uyfbmj jy2fAaN2HLNDqUaAaARvT+Dr7qd6HYzD5lY9tzXG0XhfB0LPIVYSnkaMu5yP+a/PbNGH 1K1oTHHpZkbgdlwhxA0OktmclxMjn+ndiWwM1JNqvHv3b/FXdf16H3gcsLnejRc5H0ev SYh7ixxgiDrDz8sjaeTmcY/66uBGtfLxpdezo0ym2HE3J+0sANR8e3bcbt9CFWitfe/I 47iUSH83jG7m7d/wo72P3+L6Jk17k22t0B9ImNUmlBXnQlThz05WeVD650cm0T4AH/1m FIyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=6TOYRVLSYm3pTlQplTTOyVWUN3SL+or4WplAj6u3u6A=; b=Xno8CwPayOk4HL77nVNE+JHcoThLisbiekRV3C5tSNtQ9sPqLgjVvyUAWCMnFozGuQ /taoR2/1x9cV/0+Qo7xMKBBqCAHJOr7hMfIDNsMWPKua+XiQe5XuoSinrYcFWXL37cPU GB/KuI5SK3tTwrBxH6EvkD2566zZ7GeEsfj6gPLGQZIaWmTVwHYtvOcXQ6jYaBPcwdjD N70taE9Y1xsmjH75QKTOB3dWBKZIvdxkaJvfL1oYODhcXRp43I9pk3Z4EE+XboAzAtmM UXIhZoph4ZWLxNNlwzJCAqC8AZ3xu546apDvGUXLpOGc1PEuSEabUQvcfpQV3bRMx43n JrkQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@lunn.ch header.s=20171124 header.b=lBLB0Yol; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k132si25095284pgc.131.2019.04.26.07.22.12; Fri, 26 Apr 2019 07:22:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@lunn.ch header.s=20171124 header.b=lBLB0Yol; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726360AbfDZOVO (ORCPT + 99 others); Fri, 26 Apr 2019 10:21:14 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:45540 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726144AbfDZOVO (ORCPT ); Fri, 26 Apr 2019 10:21:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=6TOYRVLSYm3pTlQplTTOyVWUN3SL+or4WplAj6u3u6A=; b=lBLB0YolKVoDNMdFde2qgyArKA uDp6BvGQ/+RJI1QDbFvUjoI71zb9wwyEWHdpNbwXXMnyec5DdkFWVUEwxKo44LcnC63rW/uj1Aaok YTwMkwUV27KSMdZbhqP3lTuZdm/M8Iz4HhtduBhSL1P4oeWIOyNEjEoZl7MJjhMdEC5U=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hK1ip-0001G8-6M; Fri, 26 Apr 2019 16:21:03 +0200 Date: Fri, 26 Apr 2019 16:21:03 +0200 From: Andrew Lunn To: Esben Haabendal Cc: netdev@vger.kernel.org, "David S. Miller" , Michal Simek , Luis Chamberlain , YueHaibing , Yang Wei , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 08/12] net: ll_temac: Fix iommu/swiotlb leak Message-ID: <20190426142103.GI14432@lunn.ch> References: <20190426073231.4008-1-esben@geanix.com> <20190426073231.4008-9-esben@geanix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190426073231.4008-9-esben@geanix.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 26, 2019 at 09:32:27AM +0200, Esben Haabendal wrote: > Unmap the actual buffer length, not the amount of data received. Hi Esben The patch Subject does not seem to match the content? Also, there can be performance advantages of just unmapping the received length. The unmap operation does a cache invalidate, which can be expensive. Consider the effort of unmapping a 64 byte ACK vs 9K jumbo frame? Andrew > Signed-off-by: Esben Haabendal > --- > drivers/net/ethernet/xilinx/ll_temac_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c > index 309f149..56d8077 100644 > --- a/drivers/net/ethernet/xilinx/ll_temac_main.c > +++ b/drivers/net/ethernet/xilinx/ll_temac_main.c > @@ -821,7 +821,7 @@ static void ll_temac_recv(struct net_device *ndev) > length = be32_to_cpu(cur_p->app4) & 0x3FFF; > > dma_unmap_single(ndev->dev.parent, be32_to_cpu(cur_p->phys), > - length, DMA_FROM_DEVICE); > + XTE_MAX_JUMBO_FRAME_SIZE, DMA_FROM_DEVICE); > > skb_put(skb, length); > skb->protocol = eth_type_trans(skb, ndev); > -- > 2.4.11 >