Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <06b89c06-462a-788e-20f9-aa71ac1507b4@siemens.com>
In-Reply-To: <06b89c06-462a-788e-20f9-aa71ac1507b4@siemens.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Fri, 26 Apr 2019 17:44:54 +0300
Message-ID: <CAHp75VevX_TAzgrmBTF0KY_5ZycG6VNnAY8CQf+nR-kdSKKrXQ@mail.gmail.com>
Subject: Re: [PATCH] mfd: intel_quark_i2c_gpio: Adjust IOT2000 matching
To:     Jan Kiszka <jan.kiszka@siemens.com>
Cc:     Lee Jones <lee.jones@linaro.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        Su Bao Cheng <baocheng.su@siemens.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Apr 18, 2019 at 12:15 PM Jan Kiszka <jan.kiszka@siemens.com> wrote:
>
> From: Su Bao Cheng <baocheng.su@siemens.com>
>
> Since there are more IOT2040 variants with identical hardware but
> different asset tags, the asset tag matching should be adjusted to
> support them.
>
> For the board name "SIMATIC IOT2000", currently there are 2 types of
> hardware, IOT2020 and IOT2040. Both are identical regarding the
> intel_quark_i2c_gpio. In the future there will be no other devices with
> the "SIMATIC IOT2000" DMI board name but different hardware. So remove
> the asset tag matching from this driver.
>

Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Signed-off-by: Su Bao Cheng <baocheng.su@siemens.com>
> Reviewed-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  drivers/mfd/intel_quark_i2c_gpio.c | 10 ----------
>  1 file changed, 10 deletions(-)
>
> diff --git a/drivers/mfd/intel_quark_i2c_gpio.c b/drivers/mfd/intel_quark_i2c_gpio.c
> index 5bddb84cfc1f..11adbf77960d 100644
> --- a/drivers/mfd/intel_quark_i2c_gpio.c
> +++ b/drivers/mfd/intel_quark_i2c_gpio.c
> @@ -74,16 +74,6 @@ static const struct dmi_system_id dmi_platform_info[] = {
>         {
>                 .matches = {
>                         DMI_EXACT_MATCH(DMI_BOARD_NAME, "SIMATIC IOT2000"),
> -                       DMI_EXACT_MATCH(DMI_BOARD_ASSET_TAG,
> -                                       "6ES7647-0AA00-0YA2"),
> -               },
> -               .driver_data = (void *)400000,
> -       },
> -       {
> -               .matches = {
> -                       DMI_EXACT_MATCH(DMI_BOARD_NAME, "SIMATIC IOT2000"),
> -                       DMI_EXACT_MATCH(DMI_BOARD_ASSET_TAG,
> -                                       "6ES7647-0AA00-1YA2"),
>                 },
>                 .driver_data = (void *)400000,
>         },
> --
> 2.16.4


-- 
With Best Regards,
Andy Shevchenko