Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp742575yba; Fri, 26 Apr 2019 08:04:14 -0700 (PDT) X-Google-Smtp-Source: APXvYqzY7khMLtreLzRtFpNw5TM23GOnVMtg0WKuMEEqXESOR7Lbs5dB6eZLN/G7EHGprv+7Rfan X-Received: by 2002:a63:5041:: with SMTP id q1mr21145078pgl.386.1556291054119; Fri, 26 Apr 2019 08:04:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556291054; cv=none; d=google.com; s=arc-20160816; b=h8AQkkM8zhJbqCFsdLeMJR4U8/VfFigR4ac1T0ckpQiMhUdmKfoCk5oYcvPrAxJKLF DIlQiJtwlnoAjX3hLu24jPOCJcSAC8lYeg5K0NdJK6iepeMG/DyrNdmnZ+DTmLu3uGcA vr5IEDOjGn1UeBgnTUinEZ9rW2g95f5GZoS3DATRTKkijSJhm20oZ1j5oDOW/5g/+MKE ZcpnWRoyW5+16oXYwHTiZdHVBv/lYzkwkm3S4g3L1xspbRcV4zAPmVPlSY4E7S1avWSX 3cerwl3C2fsVUskDtSwTcvS4yfywwgkWKJHU9TkNx6tpJ7Nx11fIPng2FbB9xpuPbD8z w6TA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=7qRndfjaZ1nghm2K8LGLxpqOdEUyt/7dZ4JawHEeR4o=; b=NOHqxk3Mj7f+HE9iGCDDC00V7OcU3XqUWaDAmLqsOLPcdGB4jm4Q25yq7tLltX16dK 5U5wY4piRMBNoNwJDit194TVpVLpJQrpnJR59YD1pKdOzEmOQ9YtwykcJ2yiQFsGXdv0 24bsczt0AoreHhGyg2TMptTymVNfiAB8yvOSQRaBZ0ipvpOywNZwdLW96Ypy4S8jDcNl bLJEpvGhlqoVdf65A3vq5biw9lkKpoGk9n/BpBPZixVWVVULDLZltQ//yrMjhkwvMmaL 3owUp//Z9j3AoFBcyNlQr3Ajfg9cttPOFYet2miNB5u3KImcCHhjDD81cT41wY7irCap b6MA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d1si13645420pgv.242.2019.04.26.08.03.53; Fri, 26 Apr 2019 08:04:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726229AbfDZPCp (ORCPT + 99 others); Fri, 26 Apr 2019 11:02:45 -0400 Received: from 8bytes.org ([81.169.241.247]:37896 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725965AbfDZPCp (ORCPT ); Fri, 26 Apr 2019 11:02:45 -0400 Received: by theia.8bytes.org (Postfix, from userid 1000) id E1FA7D91; Fri, 26 Apr 2019 17:02:43 +0200 (CEST) Date: Fri, 26 Apr 2019 17:02:42 +0200 From: Joerg Roedel To: Tom Murphy Cc: iommu@lists.linux-foundation.org, murphyt7@tcd.ie, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Remove old no iommu direct mapping code Message-ID: <20190426150242.GL24576@8bytes.org> References: <20190423200335.3888-1-tmurphy@arista.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190423200335.3888-1-tmurphy@arista.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 23, 2019 at 09:03:34PM +0100, Tom Murphy wrote: > These checks were intended to handle devices not mapped by the IOMMU. > Since the AMD IOMMU driver uses per-device dma_ops these functions can > no longer be called by direct mapped devices. So these checks aren't > needed anymore. > > Signed-off-by: Tom Murphy > --- > drivers/iommu/amd_iommu.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) This has already been done by Christoph, see https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git/commit/?id=7a5dbf3ab2f04905cf8468c66fcdbfb643068bcb Regards, Joerg