Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <9d9f2e4465ce80593b3a5d08e9948304bdcefbf4.camel@sipsolutions.net>
Subject: Re: [PATCH net-next 0/3] make nla_nest_start() add NLA_F_NESTED flag
From:   Johannes Berg <johannes@sipsolutions.net>
To:     David Ahern <dsahern@gmail.com>, Michal Kubecek <mkubecek@suse.cz>,
        netdev@vger.kernel.org
Cc:     "David S. Miller" <davem@davemloft.net>,
        Jiri Pirko <jiri@mellanox.com>,
        Pablo Neira Ayuso <pablo@netfilter.org>,
        Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
        Florian Westphal <fw@strlen.de>,
        "netfilter-devel@vger.kernel.org" <netfilter-devel@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Date:   Fri, 26 Apr 2019 18:02:38 +0200
In-Reply-To: <47f6daf9-2d14-1566-8ed1-fb5d4dd57bf8@gmail.com> (sfid-20190426_170019_042586_CEF2CE11)
References: <cover.1556269635.git.mkubecek@suse.cz>
         <1dcb87486a96785e3b9e6f337392aa904d977a0d.camel@sipsolutions.net>
         <20190426111954.GG26549@unicorn.suse.cz>
         <a3626aeca20280e8253b575fe72309b2009474a8.camel@sipsolutions.net>
         <20190426115629.GH26549@unicorn.suse.cz>
         <18db9ac8b398b215e3523dd5b79c7f86e21864ce.camel@sipsolutions.net>
         <47f6daf9-2d14-1566-8ed1-fb5d4dd57bf8@gmail.com>
         (sfid-20190426_170019_042586_CEF2CE11)
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 2019-04-26 at 09:00 -0600, David Ahern wrote:
> 
> What is a valid use case for an attribute sometimes being a nest and
> sometimes not? That seems really weird to me (ie., wrong). They should
> be 2 separate attributes even if the backend processing is the same.

Yeah, well, in the mentioned case - NL80211_ATTR_VENDOR_DATA - we
basically have something that each driver (sometimes each operation that
uses it) decides what it means, and most drivers like proper netlink
attributes so have nested stuff there. Sometimes not, though in Prague
we decided we should make that documented by requiring a nested policy
and (perhaps, TBD) using something like an ERR_PTR() for "I really want
this to be binary".

I think as far as this particular attribute is concerned the ship has
sailed, but in the future I'd probably advocate having two attributes.

johannes