Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261519AbVA1Rz7 (ORCPT ); Fri, 28 Jan 2005 12:55:59 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261516AbVA1Ryc (ORCPT ); Fri, 28 Jan 2005 12:54:32 -0500 Received: from grendel.digitalservice.pl ([217.67.200.140]:35498 "HELO mail.digitalservice.pl") by vger.kernel.org with SMTP id S261512AbVA1Rwg (ORCPT ); Fri, 28 Jan 2005 12:52:36 -0500 From: "Rafael J. Wysocki" To: Martin Zwickel Subject: Re: [RFC][PATCH] swsusp: do not use higher order memory allocations on suspend Date: Fri, 28 Jan 2005 18:52:43 +0100 User-Agent: KMail/1.7.1 Cc: LKML , hugang@soulinfo.com, Pavel Machek , Nigel Cunningham References: <200501281454.23167.rjw@sisk.pl> <20050128150756.1d6976cb@phoebee> In-Reply-To: <20050128150756.1d6976cb@phoebee> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200501281852.43689.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 974 Lines: 35 On Friday, 28 of January 2005 15:07, Martin Zwickel wrote: > > @@ -373,15 +377,22 @@ > > > > static int write_pagedir(void) > > { > > - unsigned long addr = (unsigned long)pagedir_nosave; > > int error = 0; > > - int n = SUSPEND_PD_PAGES(nr_copy_pages); > > - int i; > > + unsigned n = 0; > > + struct pbe * pbe; > > + > > + printk( "Writing pagedir ..."); > > > > + > > + pr_debug("\b\b\bdone (%u pages)\n", n); > > Just cosmetic: > Why do you use pr_debug here instead of printk like you did above? By mistake. :-) Thanks! Greets, RJW -- - Would you tell me, please, which way I ought to go from here? - That depends a good deal on where you want to get to. -- Lewis Carroll "Alice's Adventures in Wonderland" - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/