Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1556297285.22365.4.camel@suse.de>
Subject: Re: [RFC PATCH RESEND] i2c-piix4: Add Hygon Dhyana SMBus support
From:   Jean Delvare <jdelvare@suse.de>
To:     Pu Wen <puwen@hygon.cn>
Cc:     bp@alien8.de, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org, stable <stable@vger.kernel.org>
Date:   Fri, 26 Apr 2019 18:48:05 +0200
In-Reply-To: <0c895129-23af-2fc6-0c99-61348a69f961@hygon.cn>
References: <1555938607-2865-1-git-send-email-puwen@hygon.cn>
         <20190426113751.77befab1@endymion>
         <0c895129-23af-2fc6-0c99-61348a69f961@hygon.cn>
Organization: Suse Linux
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 2019-04-26 at 22:23 +0800, Pu Wen wrote:
> On 2019/4/26 17:38, Jean Delvare wrote:
> > I would like you to also document the new supported chipset in
> > drivers/i2c/busses/Kconfig and Documentation/i2c/busses/i2c-piix4 as
> > well as in the header comment of i2c-piix4.c itself. I know it seems
> > redundant but it helps the user know which driver they need.
> 
> Because Hygon uses the same PCI device ID of AMD's, so is it appropriate 
> to document with the name "Hygon CZ" or just "Hygon"?

"Hygon CZ" please, as Hygon is the vendor not the device, and I can
imagine you may create more devices in the future.

Thanks,
-- 
Jean Delvare
SUSE L3 Support