Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp896293yba; Fri, 26 Apr 2019 10:31:54 -0700 (PDT) X-Google-Smtp-Source: APXvYqyP/6SlgGhpeCd+n1vhhrGzvHft7nNJkitzaDvV8qEA8Sfphsvi7SAtEkRKeyVwp9oyEMJk X-Received: by 2002:a17:902:2be8:: with SMTP id l95mr48283410plb.330.1556299914196; Fri, 26 Apr 2019 10:31:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556299914; cv=none; d=google.com; s=arc-20160816; b=Jd9TNpObu1S0FaXoxeOltA1n0mwx3tEQ/fSxH65qz9nKAKOyNRqMScU1C0jWom0uTC qMaMSKsp3Lv619C06/AKsVANtChkx+l/S4RZOobTz3jcgG30GPNqWAHh4S4PAki0wGS2 P/QTrL4Z3tHe7U5cpcmGgdIwB7eyyHYgFHQ3thvtTriDYTsrEni8sy5LWQ5FS91FeS5y 4LfQDVFEhwjxqz8nQsbP1uJxL42T6YtNCLtq0qrMVM+NpW0mKysliXcQygi4H5CCVIsa mrZhJM4269HBQbUcoHPEWIV7qc6X20eFKs2DTJkp8V0lJnYngnEl1lPm/ouoyjkv2gM5 hwXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=OhhuYtNA1+qn4e/Q4iPF1W36XeGrjxzSEWk/AWLcHao=; b=Sfom9NfOa08kl8fgTkeB8CjhIVPt8liiumavTpJSOFmvmXy9s+ItP2zjGM1RjISH09 P6Tf1g5hZBUVE6/rNGvnwjP66cCpoMz4A/as8ym5zppusecKcimy1pRIMiqMTtmCLf/p /rzcvmatsCmjSZpMmZv40dUdGuY53SBzuceWIf2d2CHy5H9Sg/52s5FY5/Cjyi1mbcdc k3c7tPDzq4zEWn31Rcob8COkCCQokeX6MUsl9VKA+Ez+Lhieqfw3o21w8UZhJ1lTmzig h8Sir5hvlYIkzvC/ZIgN7xxiMWzuES5EX6gDal1Oxk25aGnoBOcEcHrBt5uJwa1vJcz9 c/AA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f88si19059602plf.256.2019.04.26.10.31.37; Fri, 26 Apr 2019 10:31:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726255AbfDZRaj (ORCPT + 99 others); Fri, 26 Apr 2019 13:30:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45160 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725944AbfDZRai (ORCPT ); Fri, 26 Apr 2019 13:30:38 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AEB2259466; Fri, 26 Apr 2019 17:30:38 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.43.17.159]) by smtp.corp.redhat.com (Postfix) with SMTP id 5EE6A1001E6C; Fri, 26 Apr 2019 17:30:37 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Fri, 26 Apr 2019 19:30:37 +0200 (CEST) Date: Fri, 26 Apr 2019 19:30:36 +0200 From: Oleg Nesterov To: Roman Gushchin Cc: Roman Gushchin , Tejun Heo , Kernel Team , "cgroups@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v10 4/9] cgroup: cgroup v2 freezer Message-ID: <20190426173035.GA24755@redhat.com> References: <20190405174708.1010-1-guro@fb.com> <20190405174708.1010-5-guro@fb.com> <20190424160237.GH16167@redhat.com> <20190424221034.GB22896@tower.DHCP.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190424221034.GB22896@tower.DHCP.thefacebook.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Fri, 26 Apr 2019 17:30:38 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/24, Roman Gushchin wrote: > > of the patchset. In the current iteration I'd replace it with: > > WARN_ON_ONCE(cgroup_task_frozen(tsk)); > > just to make sure we're not leaking the frozen bit. > Do you agree? Yes sure, Oleg.