Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 26 Apr 2019 19:15:15 +0100
From:   Alan Cox <gnomes@lxorguk.ukuu.org.uk>
To:     Sugaya Taichi <sugaya.taichi@socionext.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jslaby@suse.com>, Arnd Bergmann <arnd@arndb.de>,
        Takao Orito <orito.takao@socionext.com>,
        Kazuhiro Kasai <kasai.kazuhiro@socionext.com>,
        Shinji Kanematsu <kanematsu.shinji@socionext.com>,
        Jassi Brar <jaswinder.singh@linaro.org>,
        Masami Hiramatsu <masami.hiramatsu@linaro.org>,
        linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH v3] serial: Add Milbeaut serial control
Message-ID: <20190426191515.757e6015@alans-desktop>
In-Reply-To: <1555555916-22251-1-git-send-email-sugaya.taichi@socionext.com>
References: <1555555916-22251-1-git-send-email-sugaya.taichi@socionext.com>
Organization: Intel Corporation
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

O
> +static void mlb_usio_set_termios(struct uart_port *port,
> +			struct ktermios *termios, struct ktermios *old)
> +{
> +	unsigned int escr, smr = MLB_USIO_SMR_SOE;
> +	unsigned long flags, baud, quot;
> +
> +	switch (termios->c_cflag & CSIZE) {
> +	case CS5:
> +		escr = MLB_USIO_ESCR_L_5BIT;
> +		break;
> +	case CS6:
> +		escr = MLB_USIO_ESCR_L_6BIT;
> +		break;
> +	case CS7:
> +		escr = MLB_USIO_ESCR_L_7BIT;
> +		break;
> +	case CS8:
> +	default:
> +		escr = MLB_USIO_ESCR_L_8BIT;
> +		break;
> +	}
> +
> +	if (termios->c_cflag & CSTOPB)
> +		smr |= MLB_USIO_SMR_SBL;
> +
> +	if (termios->c_cflag & PARENB) {
> +		escr |= MLB_USIO_ESCR_PEN;
> +		if (termios->c_cflag & PARODD)
> +			escr |= MLB_USIO_ESCR_P;
> +	}

If you don't suport CMSPAR then clear that bit in termios as well

> +	/* Set hard flow control */
> +	if (of_property_read_bool(port->dev->of_node, "auto-flow-control") ||
> +			(termios->c_cflag & CRTSCTS))
> +		escr |= MLB_USIO_ESCR_FLWEN;

That's just broken. The termios bits are the definitive things for the
port, and in addition even if they are forced you need to correct the
termios data.

You might want to control flow control *at boot* with an OF property but
doing it post boot is just busted.

Alan