Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190426182948.GA10020@bharath12345-Inspiron-5559>
In-Reply-To: <20190426182948.GA10020@bharath12345-Inspiron-5559>
From:   Bharath Veda <linux.bhar@gmail.com>
Date:   Sat, 27 Apr 2019 00:52:25 +0530
Message-ID: <CAMwgTV7k=32sSFYp38Ft8M-oXhcEqcOByO=fpUBMeS1_XvzN1g@mail.gmail.com>
Subject: Re: [PATCH] drivers/char/random.c: Make add_hwgenerator_randomness static
To:     tytso@mit.edu, arnd@arndb.de, Greg KH <gregkh@linuxfoundation.org>
Cc:     LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

Please ignore this patch. It breaks the build.

Thank you

On Fri, Apr 26, 2019 at 11:59 PM Bharath Vedartham <linux.bhar@gmail.com> wrote:
>
> Make add_hwgenerator_randomness static as it is only declared on
> drivers/char/random.c
>
> Signed-off-by: Bharath Vedartham <linux.bhar@gmail.com>
> ---
>  drivers/char/random.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/random.c b/drivers/char/random.c
> index 38c6d1a..08fd00a 100644
> --- a/drivers/char/random.c
> +++ b/drivers/char/random.c
> @@ -2342,7 +2342,7 @@ randomize_page(unsigned long start, unsigned long range)
>   * Those devices may produce endless random bits and will be throttled
>   * when our pool is full.
>   */
> -void add_hwgenerator_randomness(const char *buffer, size_t count,
> +static void add_hwgenerator_randomness(const char *buffer, size_t count,
>                                 size_t entropy)
>  {
>         struct entropy_store *poolp = &input_pool;
> --
> 2.7.4
>