Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1194515yba; Fri, 26 Apr 2019 16:09:30 -0700 (PDT) X-Google-Smtp-Source: APXvYqytztCaj05yQMh8IiCOIoXijVubhLTVpaDGTwiVrQUhbFCl7uhahdzdAdmyPTMbf2bKpIML X-Received: by 2002:a17:902:f094:: with SMTP id go20mr48879994plb.159.1556320170073; Fri, 26 Apr 2019 16:09:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556320170; cv=none; d=google.com; s=arc-20160816; b=Gwu6c5wQv9MMRmTmJTAKx2/V0vrpKY5nrpho2+APp0v9qVdx/lWXjALrHrYJetwY9n yTo0zT45rPOgVAaGvwvtmSk7Vyxw1DIFlkmuxuUp4NxiuE5sJJVQJsgsRD6d8XUwTwUt 2LHf2kw6MdRsMLTtkhOM7obEgk5cLmZmVRkKAS9E+AoWI1ePeVAz6G5WXLu/F5AvT0ZP tU+fnCC/Gz3cYfM6jo7smWLgfnAbD14HJi76RGkGDABQo723Xns5KCh4Tz+P13ds+1uN s18fSC1BVq7239jcWyPXHxDw3gZng1JB5yZCLRJOPvi4eilz1b3aCgOZyTxFc3NnNMr7 GcuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=UZ1PcHB4MXXq9ntl4VMmzNY65z4mlEMCmN6YgrJXlmM=; b=s2KJH++L6ShburKKfX2m9BcYXuAt0LLZ4ycCfZEgZJiBLVCvwqxhTjPuRjV6tGo0bR wtPTRcyhhrW2iX7383apRHufZZ3vyU39BcPYrQgsvTU0IDUkIkw1qE4Yncamqfoa+eJB lxoZuSL6P0E0IBpkuFqY1Zy8a37vvU2+ZC1jm6vQZfwhFW1PnsBlshpcqgREGsraqgPV R4u63CCzLcu/CcoFQbKMQR0Vz5qQ4gbGMzgjdsDxfZnaZo56AVYEyr7nVMwRTet0GjVB dzjaxlYt+HpEvYDR1yQAwCQlO+y5uYAxz+B3UByqtNXJ4ZwcJyrBBS5UZDALqVN93Yxu pqxA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k24si26543171pfk.284.2019.04.26.16.09.04; Fri, 26 Apr 2019 16:09:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727235AbfDZXHq (ORCPT + 99 others); Fri, 26 Apr 2019 19:07:46 -0400 Received: from smtp-out.xnet.cz ([178.217.244.18]:25218 "EHLO smtp-out.xnet.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727158AbfDZXHp (ORCPT ); Fri, 26 Apr 2019 19:07:45 -0400 Received: from meh.true.cz (meh.true.cz [108.61.167.218]) (Authenticated sender: petr@true.cz) by smtp-out.xnet.cz (Postfix) with ESMTPSA id 6274D36BD; Sat, 27 Apr 2019 01:07:43 +0200 (CEST) Received: by meh.true.cz (OpenSMTPD) with ESMTP id 96dda932; Sat, 27 Apr 2019 01:07:41 +0200 (CEST) From: =?UTF-8?q?Petr=20=C5=A0tetiar?= To: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Nicolas Ferre , "David S. Miller" Cc: Andrew Lunn , Florian Fainelli , Heiner Kallweit , Rob Herring , Frank Rowand , Srinivas Kandagatla , Maxime Ripard , Alban Bedel , =?UTF-8?q?Petr=20=C5=A0tetiar?= Subject: [PATCH 3/4] net: macb: Drop nvmem_get_mac_address usage Date: Sat, 27 Apr 2019 01:06:41 +0200 Message-Id: <1556320002-26213-4-git-send-email-ynezz@true.cz> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1556320002-26213-1-git-send-email-ynezz@true.cz> References: <1556320002-26213-1-git-send-email-ynezz@true.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org of_get_mac_address now uses NVMEM under the hood, so it's not necessary to call it manually anymore. Signed-off-by: Petr Štetiar --- drivers/net/ethernet/cadence/macb_main.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c index 3da2795..1b98bc8 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -4172,16 +4172,10 @@ static int macb_probe(struct platform_device *pdev) bp->rx_intr_mask |= MACB_BIT(RXUBR); mac = of_get_mac_address(np); - if (mac) { + if (mac) ether_addr_copy(bp->dev->dev_addr, mac); - } else { - err = nvmem_get_mac_address(&pdev->dev, bp->dev->dev_addr); - if (err) { - if (err == -EPROBE_DEFER) - goto err_out_free_netdev; - macb_get_hwaddr(bp); - } - } + else + macb_get_hwaddr(bp); err = of_get_phy_mode(np); if (err < 0) { -- 1.9.1