Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [RFC PATCH RESEND] i2c-piix4: Add Hygon Dhyana SMBus support
To:     Jean Delvare <jdelvare@suse.de>
CC:     "bp@alien8.de" <bp@alien8.de>,
        "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        stable <stable@vger.kernel.org>
References: <1555938607-2865-1-git-send-email-puwen@hygon.cn>
 <20190426113751.77befab1@endymion>
 <0c895129-23af-2fc6-0c99-61348a69f961@hygon.cn>
 <1556297285.22365.4.camel@suse.de>
From:   Pu Wen <puwen@hygon.cn>
Message-ID: <8ec649c6-5282-6fb1-a1ee-a88dc897d644@hygon.cn>
Date:   Sat, 27 Apr 2019 10:37:49 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <1556297285.22365.4.camel@suse.de>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2019/4/27 0:48, Jean Delvare wrote:
> On Fri, 2019-04-26 at 22:23 +0800, Pu Wen wrote:
>> On 2019/4/26 17:38, Jean Delvare wrote:
>>> I would like you to also document the new supported chipset in
>>> drivers/i2c/busses/Kconfig and Documentation/i2c/busses/i2c-piix4 as
>>> well as in the header comment of i2c-piix4.c itself. I know it seems
>>> redundant but it helps the user know which driver they need.
>>
>> Because Hygon uses the same PCI device ID of AMD's, so is it appropriate
>> to document with the name "Hygon CZ" or just "Hygon"?
> 
> "Hygon CZ" please, as Hygon is the vendor not the device, and I can

Okay.

> imagine you may create more devices in the future.

Surely.

-- 
Regards,
Pu Wen