Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1571204yba; Sat, 27 Apr 2019 02:20:51 -0700 (PDT) X-Google-Smtp-Source: APXvYqzNLjahAPoa+b6SDUoOqhO5V2MS/IK20Qt59MvavVxQsHRp6DAi4gT4Kr3Zt9+yLPESAyA8 X-Received: by 2002:a63:c749:: with SMTP id v9mr26411504pgg.432.1556356851061; Sat, 27 Apr 2019 02:20:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556356851; cv=none; d=google.com; s=arc-20160816; b=HZiRIDxGU4bcMkldjW0LIGt6g0X0nexW+kcM2ztoPZF5dZH0BvjQVhD4ycFFRzgzVK V11xr5CpL6yctSaHf+pX7ZPfN+kQ95cEuEaOO9GGr2wX4SxDqyx6tkeFKkIhtkuCdwCZ 3eqD8Ylh5LPTJl01yGWuY8vN561Th57Q3syvKhiD/aUZhlzxLp+EmXjDBJZy6aODDlBo WMSWybme08HG5rKQrJZJFapq06g8hdzVXa5lTI/mMC+NeHPJmGPCKnlzZF2JH1oPB8Cw 4oOzjo91aLVKY74x4wVKz3JyP6WH/i/LREpZ2/bBdFbZp/IUrcaFCVV4XvxhA/MuJhEC J4YQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:cc:to:from:date:dkim-signature; bh=Gg/uK4hT6erpZ9y7ys+gWQjOqjeDr2lhneKZX4LpVYQ=; b=cHGMpMJTj1P2WkSduxDW04Hld6od22Bhv9W4Yp/Gk6DfIeU32/++tmBfy8FTnxEjyr SoE4Wu/nJAsVVFDKW19dIpefystMGmbcmss9gviLLdO+BYldYiDyJiCI77Qy30L6ZP8E /WRQLUuTVydE+IaXd/gVF/LoWx5Cu5+GUwem9VSOeC6Gj5JCsjQXGObBRNaXIryaPG82 TfRLTv3u/+KySB7FvHDyr5/PrtytXatmyik8DRpHW8ix55z20SKRwrdzMTmcKytNisoO 4+3Szu9cVxzUtY5ntglM+h6hGr1r3gMuPAJkUSdbEQuU6AqD7fPJcScewmNzD6uSflSt gpoA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=IxgHkvz5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v7si21636215pgs.387.2019.04.27.02.20.35; Sat, 27 Apr 2019 02:20:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=IxgHkvz5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726252AbfD0JTq (ORCPT + 99 others); Sat, 27 Apr 2019 05:19:46 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:37860 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725871AbfD0JTq (ORCPT ); Sat, 27 Apr 2019 05:19:46 -0400 Received: by mail-pf1-f195.google.com with SMTP id g3so2888551pfi.4; Sat, 27 Apr 2019 02:19:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=Gg/uK4hT6erpZ9y7ys+gWQjOqjeDr2lhneKZX4LpVYQ=; b=IxgHkvz5aNsXC9JiJTT3Kwd64QRsfiQ7GF3sH96LTAcMK4dGRiBgMQjZ4MR0Fiuf6d q9elPIf9/QoKD4BxW10NAB2e6tN7FiGAyXnsLp4/AePRVTyzeLCxG5fSjYP1vnux2RFn CoJvG7KFrGRC7zq4qWaR81ezonCDFg54Liplj3OazAOyxYqny+Wf3LbdCgMLpTqKbEoT tJqoXTQIRPwRxlE1e6d48tp0n9hgfOKe1eSiquBvLDC69OQwUuId+5OVg5sBTsY0LP+n mzZmXCuuzxlL3rSXtyR5lnl4Js0I29ZNa+7TI+QfaeGc/fsvBkp+xk+yIR3126Ytw4xq HstA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=Gg/uK4hT6erpZ9y7ys+gWQjOqjeDr2lhneKZX4LpVYQ=; b=ZcSe7YJkrMBrSfpUuGacroble6+yaoo7jxFB8UdZdRjwsGOkd3AFPqR78bqqAeF7JT Xhg5eO8KGuZy+t1iN31UxYLrFAn+XpFmakT/447nVGJ2C4ryIi+K8RJXvUqOUgqf5rEo JU6p4FIbHEEtwte+LdQRYVMxaWzANEu22x73GEJ61ayp2LQhyAiF8v+d/YV0/IjMCq12 CTe22Ck5QORF6Lstq15cQpFN5KvyNF3SxCmb8TL+8T4/HVGC/M+3EU1DpPLVzmL69QK4 vT8F/scIs5a90yzldONgUiOpbb+rGo0pcMZ0KTNFz0T94V9qRW9sDILq39FiSyqrmdHd QRhA== X-Gm-Message-State: APjAAAUmUndwn5/v1MGwFpgy4PzbmYzBtAbSlpXpj8ldPFF7R9d7EGjj LgA9tcEmLLCF/TAFdg2LGfBrS3C2o4E= X-Received: by 2002:a63:fd58:: with SMTP id m24mr24643145pgj.298.1556356785499; Sat, 27 Apr 2019 02:19:45 -0700 (PDT) Received: from haolee.io ([2600:3c01::f03c:91ff:fe77:6cf4]) by smtp.gmail.com with ESMTPSA id u6sm39870871pfm.10.2019.04.27.02.19.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 27 Apr 2019 02:19:45 -0700 (PDT) Date: Sat, 27 Apr 2019 17:19:43 +0800 From: Hao Lee To: gregkh@linuxfoundation.org Cc: jslaby@suse.com, haolee.swjtu@gmail.com, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] tty: serial: 8250: Fix type field in format string Message-ID: <20190427091943.GA3810@haolee.io> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The dev_dbg statement should print the value of uart.port.mapbase instead of its address. Besides that, uart.port.irq and uart.port.iotype are all unsigned types, so using %u is more appropriate. Signed-off-by: Hao Lee --- drivers/tty/serial/8250/8250_pnp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/8250/8250_pnp.c b/drivers/tty/serial/8250/8250_pnp.c index 431e69a5a6a0..9dea11baf479 100644 --- a/drivers/tty/serial/8250/8250_pnp.c +++ b/drivers/tty/serial/8250/8250_pnp.c @@ -462,8 +462,8 @@ serial_pnp_probe(struct pnp_dev *dev, const struct pnp_device_id *dev_id) return -ENODEV; dev_dbg(&dev->dev, - "Setup PNP port: port %lx, mem %pa, irq %d, type %d\n", - uart.port.iobase, &uart.port.mapbase, + "Setup PNP port: port %#lx, mem %#lx, irq %u, type %u\n", + uart.port.iobase, uart.port.mapbase, uart.port.irq, uart.port.iotype); if (flags & CIR_PORT) { -- 2.14.5