Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1693633yba; Sat, 27 Apr 2019 05:12:15 -0700 (PDT) X-Google-Smtp-Source: APXvYqzUTYrXGNdgiHUlu4Y1AiR9oMBkFJqTDgvGWrRL2WI44HiMjyH7mbGD2z7AcLozPbCz/CBB X-Received: by 2002:a63:4558:: with SMTP id u24mr46807203pgk.225.1556367135665; Sat, 27 Apr 2019 05:12:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556367135; cv=none; d=google.com; s=arc-20160816; b=G4F8dqCPMCI1mFjiG5IoxT/Csjj0LpgvkAngI6wjrVscssf201EW1QYVJHtfsni+7y JjalPnSkaxfwrDd4Lc3AnavqtfguXR5eXeETgS36KfqSqEH0wNIjpGtIFELr0fmfd9Ru 8KTL8PAolw3XrRpw2y8NqvxTfjp9eII/pE+9yNkn6iw4VS4n6VvjRkyRLeAiJZRxn4nW vLx+svAOrf47bOgp1oTVOZfxQNQqSTbOLD0eKpPzbn9/zzztxNpscgdNb0JNQwpSqDP0 3heU6Om/f5MFZCPPNirBI2nLfWqEyafPR05jp+NyUuCZGccgZmKL6zUZpvr+DCDdmSFK 4NRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=IFpX+J5M5XuHngexC6wi8e4mszKw21s+5lITZly14zo=; b=TjOit1hpLSMvas9UpDyMXQu96mJOjJgYZszSor81LSgdrgANpTELlNI+ioD5G2X1Tu eT1wr9MooNu4PTmatiZotHCgfEy/eFZBTcSg7UIwYofDAPsT2owrBw+GNlkyFcAZpL1x LAL9UaDOeQv7XcwkOugDe6Iu5nJuv8WvpKZJITxGsQOsEzZrk20B55AqSa+b1Mq/sPcu f01MVbe08Zrszb9wwvgkZ2MIvNhTL94yRNJ/HwdA1IUHa7NrQThPpemdh8uqYU8xLTyy HE1pi15/gU+Civouv8X4kAUrjh14PuwRXz3RllBLfLOLNHvd393sAfut/lmHGwIQMnFv pilQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g97si28089369plb.70.2019.04.27.05.11.59; Sat, 27 Apr 2019 05:12:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726337AbfD0MLI (ORCPT + 99 others); Sat, 27 Apr 2019 08:11:08 -0400 Received: from saturn.retrosnub.co.uk ([46.235.226.198]:41888 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726004AbfD0MLI (ORCPT ); Sat, 27 Apr 2019 08:11:08 -0400 Received: from archlinux (cpc91196-cmbg18-2-0-cust659.5-4.cable.virginm.net [81.96.234.148]) by saturn.retrosnub.co.uk (Postfix; Retrosnub mail submission) with ESMTPSA id 29D079E8528; Sat, 27 Apr 2019 13:11:05 +0100 (BST) Date: Sat, 27 Apr 2019 13:11:03 +0100 From: Jonathan Cameron To: Alexandre Cc: Peter Meerwald-Stadler , linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, baylibre-upstreaming@groups.io Subject: Re: [PATCH v2 3/3] iio: Add PAT9125 optical tracker sensor Message-ID: <20190427131103.1ce00b1c@archlinux> In-Reply-To: <8abd482d-ae1e-ba86-c050-317fc0208fe6@baylibre.com> References: <1556016046-31231-1-git-send-email-amergnat@baylibre.com> <1556016046-31231-4-git-send-email-amergnat@baylibre.com> <8abd482d-ae1e-ba86-c050-317fc0208fe6@baylibre.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 23 Apr 2019 16:06:56 +0200 Alexandre wrote: > Hi Peter, > > On 4/23/19 13:33, Peter Meerwald-Stadler wrote: > > > > how is this thing different from a mouse device? > > I developed this driver to detect the board movement which can't be > detected by accelerometer (very slow motion). I admit this use case can > be handled by an input, and I'm agree with you, PAT9125 driver could be > an input. But this chip is able to track different kind of motion (flat > and rotation), and additionally have an interrupt GPIO, so using it like > input limit the driver potential. This chip is designed to work in > industrial measurement or embedded systems, and the IIO API match with > these environments, so IIO is the best way to exploit the entire > potential of this chip. > > As I understand (from > https://www.kernel.org/doc/html/v4.12/input/event-codes.html#mice ), > mouse driver must report values when the device move. This feature > souldn't be mandatory for an optical tracker driver, specially for cases > where user prefers to use buffer or poll only when he need data. Given the 'placement' of this driver isn't totally obvious, please make sure to cc linux-input and Dmitry (maintainer) on V3. Probably no one will mind, but the last thing we want is someone else to put forward an input driver and we end up with two drivers for the same thing. Thanks, Jonathan > > All other comments will be fixed in V3. > > Regards, > > Alexandre >