Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1726514yba; Sat, 27 Apr 2019 05:56:38 -0700 (PDT) X-Google-Smtp-Source: APXvYqw1s4wzQUAzgE9QEhkJJtgPAAVPr6GTAqZrBhjBCkkOF1VsqMna2v0LjQKP4lik1LKSJZOz X-Received: by 2002:a17:902:e091:: with SMTP id cb17mr50885005plb.222.1556369798677; Sat, 27 Apr 2019 05:56:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556369798; cv=none; d=google.com; s=arc-20160816; b=gltl28Kfvecy99A56fxN9GsNpUiDKUNL2IGJkxIGm7zbG7KqcGnY/5YegNwSbjVSqL 5nNV6bOza/EjAozCptvC6dmk2LeExA2rQdtnjeTAEjfBy8fzIyDXZ3Nn0QhNohcmI10n aMk3b6pPS503Kl0e8uSgHaDfI0swVwJiUM+1r97gHy12hzIgzEaLHCwcLVmJe0LRJ7DN +lZZZ9LPtU2obdszB6WvS9L6//akeQj6c0NbrXgv61s1yz5W/FPeiztUW1QocaWOvFu5 4YJxoOFyDsfMzAptugUvAZYCf4pjHyReEj+8CucrFa5dAoifMRqEQ2ZvPzOLBmyllSuv 1/2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=JprztFuxkU+FqUCJYurw/1Zw3bNUTUL5rMgu4RIgplc=; b=ZFiaqpeeXwc4S96qlwGBZmQz1kVx2hDFjPAzOShYhqIL2HgbAk328u4YRveEj3G/Dp OzOEQEdGFi0Adz0h0v4v8AeSWuanYdfA5Lnj0bGhXr+7c2jTUIGYLnC8huYcQ+GIwY31 izouWwxfryFZe2kPq1R+Nzwojt6hmoZlc8zgu0+Z5nVQg6JgT+PO5C+06z7vCinixzys Y067MQrb0tbfM+hZMbj5h6KV/saCpAl4IpOdU8y+yYZOrvDQ3//ITSH2FHfhKj0A5NCz LwUTqQnayKT9qnlxAlH6iW9maYAHyiRfywp29ky/kyddqECvEverBD+aSiPqJj6K/H3E eJMA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v40si28125521plg.409.2019.04.27.05.56.23; Sat, 27 Apr 2019 05:56:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727568AbfD0MzH (ORCPT + 99 others); Sat, 27 Apr 2019 08:55:07 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:46351 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727111AbfD0MxU (ORCPT ); Sat, 27 Apr 2019 08:53:20 -0400 Received: from orion.localdomain ([77.2.90.210]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MoNy4-1h0jOB13NY-00ooZP; Sat, 27 Apr 2019 14:52:55 +0200 From: "Enrico Weigelt, metux IT consult" To: linux-kernel@vger.kernel.org Cc: gregkh@linuxfoundation.org, andrew@aj.id.au, andriy.shevchenko@linux.intel.com, macro@linux-mips.org, vz@mleia.com, slemieux.tyco@gmail.com, khilman@baylibre.com, liviu.dudau@arm.com, sudeep.holla@arm.com, lorenzo.pieralisi@arm.com, davem@davemloft.net, jacmet@sunsite.dk, linux@prisktech.co.nz, matthias.bgg@gmail.com, linux-mips@vger.kernel.org, linux-serial@vger.kernel.org, linux-ia64@vger.kernel.org, linux-amlogic@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org Subject: [PATCH 25/41] drivers: tty: serial: timbuart: fix formatting issues Date: Sat, 27 Apr 2019 14:52:06 +0200 Message-Id: <1556369542-13247-26-git-send-email-info@metux.net> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1556369542-13247-1-git-send-email-info@metux.net> References: <1556369542-13247-1-git-send-email-info@metux.net> X-Provags-ID: V03:K1:dHmoa7nRbvk336kCXOJfWYY+mUp7+Lq3TccEDqKxr5HUdU0dY6C yzuj71JxmIOUypO0f3pRhohp2gsNBabdH6V+CbQXryApBGH2Qcpkk/9cghWYtQLFmk7hZJw tepHWArJtIL3O9kTqTVYZs321PvyO/k3/FRT6KFOh/DxNZXymlya5ap69Okq5lTHOD9MAiI qb5auophN8XTtreo3NFMg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:1IFakNoqoRU=:g2IC/h4Lb8irwRUcRILQAP iJHtLIZRLP5jlnbby/VOYf6KFSoGCWWof47H5xhbtd8s1pPKoP5Yb+s+gq5hl2M/COoUG5QaR o6990bSVnv8p2v0LIt58daQqegXiGmvrX4cpJlges1GbZrSY/dExLVQyUMuGYKgXZ4gS+QCUi DUWO0R9GfpV81xuEYMWDH+/Bw+/jx758tebwFjMi5P+XAhZe3AahPniroFjOQEaLlPc9OACxV z0m/HLrSRyTVwbdzn/R3WyGR5qG8Qydf6ZCXFxsqGvglAFE7wX96D7Hbirq0yAOWUhNcrV99V nl69e4FBSN4KlDivbdI7WQri0vhNY84IvRo1IiEE/ZHpTnuXBQHi6+rKrCr888njr6X3lV11R +NNhXY2FcFDgZ+HnlvCcFs5NnEra46YiNivW4ohwP8Oc33TYcFbJRX84sZu0ky/s9ufExRy/n oi7lKs3kB8WUj9e5TOxMzeT8ZLvxwUxMNfWe7y49JmYueF3lZK4WAPTe0h3NNGjnfXRcs5X3q Rdh1w66GcZg+tXQYCR/QeLxPzFeL9uKD2DNxghOUH9XdzyEJC73ltkEoOg++LUt52xUMj5LRo HsVfsVAiJN/tqJkb5OzZGSqYP7kx3Ap2w5Tz+Np1uXHj61xGc5qFy/gaf3O2/0K3Be+jXiMFG 34KWo5PYCkalr9cKipeGjgZoZ3bQ0/g8AlKtDf5ADS6q158yxnznvMGHnPdlIOp7B57YTmsrg fLdpcQxU+qvrnDCsyjp/20ZqPkXCHMuK4kASFw== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix checkpatch warnings: WARNING: Missing a blank line after declarations #43: FILE: drivers/tty/serial/timbuart.c:43: + u32 ier = ioread32(port->membase + TIMBUART_IER) & ~RXFLAGS; + iowrite32(ier, port->membase + TIMBUART_IER); WARNING: Missing a blank line after declarations #50: FILE: drivers/tty/serial/timbuart.c:50: + u32 ier = ioread32(port->membase + TIMBUART_IER) & ~TXBAE; + iowrite32(ier, port->membase + TIMBUART_IER); WARNING: Missing a blank line after declarations #86: FILE: drivers/tty/serial/timbuart.c:86: + u8 ch = ioread8(port->membase + TIMBUART_RXFIFO); + port->icount.rx++; WARNING: Missing a blank line after declarations #202: FILE: drivers/tty/serial/timbuart.c:202: + u8 cts = ioread8(port->membase + TIMBUART_CTRL); + dev_dbg(port->dev, "%s - cts %x\n", __func__, cts); WARNING: Block comments use * on subsequent lines #296: FILE: drivers/tty/serial/timbuart.c:296: + /* The serial layer calls into this once with old = NULL when setting + up initially */ WARNING: Block comments use a trailing */ on a separate line #296: FILE: drivers/tty/serial/timbuart.c:296: Signed-off-by: Enrico Weigelt --- drivers/tty/serial/timbuart.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/timbuart.c b/drivers/tty/serial/timbuart.c index dcce936..d80c332 100644 --- a/drivers/tty/serial/timbuart.c +++ b/drivers/tty/serial/timbuart.c @@ -40,6 +40,7 @@ static void timbuart_stop_rx(struct uart_port *port) { /* spin lock held by upper layer, disable all RX interrupts */ u32 ier = ioread32(port->membase + TIMBUART_IER) & ~RXFLAGS; + iowrite32(ier, port->membase + TIMBUART_IER); } @@ -47,6 +48,7 @@ static void timbuart_stop_tx(struct uart_port *port) { /* spinlock held by upper layer, disable TX interrupt */ u32 ier = ioread32(port->membase + TIMBUART_IER) & ~TXBAE; + iowrite32(ier, port->membase + TIMBUART_IER); } @@ -83,6 +85,7 @@ static void timbuart_rx_chars(struct uart_port *port) while (ioread32(port->membase + TIMBUART_ISR) & RXDP) { u8 ch = ioread8(port->membase + TIMBUART_RXFIFO); + port->icount.rx++; tty_insert_flip_char(tport, ch, TTY_NORMAL); } @@ -199,6 +202,7 @@ static void timbuart_tasklet(unsigned long arg) static unsigned int timbuart_get_mctrl(struct uart_port *port) { u8 cts = ioread8(port->membase + TIMBUART_CTRL); + dev_dbg(port->dev, "%s - cts %x\n", __func__, cts); if (cts & TIMBUART_CTRL_CTS) @@ -293,7 +297,8 @@ static void timbuart_set_termios(struct uart_port *port, baud = baudrates[bindex]; /* The serial layer calls into this once with old = NULL when setting - up initially */ + * up initially + */ if (old) tty_termios_copy_hw(termios, old); tty_termios_encode_baud_rate(termios, baud, baud); @@ -500,4 +505,3 @@ static int timbuart_remove(struct platform_device *dev) MODULE_DESCRIPTION("Timberdale UART driver"); MODULE_LICENSE("GPL v2"); MODULE_ALIAS("platform:timb-uart"); - -- 1.9.1