Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1776340yba; Sat, 27 Apr 2019 06:56:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqzxVI3b948CRii8cOpe55FCuRHexAhqvjW4xV0BooRBCeydgh8pvopRnca7vcYZdFNTUp/m X-Received: by 2002:a17:902:7b96:: with SMTP id w22mr53646334pll.28.1556373394302; Sat, 27 Apr 2019 06:56:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556373394; cv=none; d=google.com; s=arc-20160816; b=RQcXYQcJFTqV0A02DNiRdB4mQNxpNqDUOvgyGxIjxaxfkBQ7YCxDiOPLBIqUojZ14F 39Zm5mPbUIGgS5HRfgYPtH/NpNssdBo3g9q1QnAzdUWy9JCDmusbVf3aZpGIctNBZyk5 35sPc+dO4SEDm4Gj2JykrfE+xPNvFd9iNfZ1B4T+upQcav1Dxo5H9jBiO6qMWOKGbfZm XVf0/ZOT5Vo2RkV6d5NHBOty5BWVW1H03YpwYo4VzoqhkrhdW7cg2ON0R8VoUTJCFoOn 72wb6JFCVlcR4/LU3EL8CXR9oLlcqoWRL4QCdUK5wJqSEx2ZL3W2mcWNOTsjw6VylMJF b0zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=qMDQAFwXmw4gFkQzw5K7sn7hnRJPIRMyTV198IyGomU=; b=JIFvZeYPenZdN3KEnhsTaJ8FdxGWAXIejYmeoerJf0adeS8Ynv2NOg3kKllWOX7b+K PWW3HHeaflecbpQHQmUfc2ZTICJVC5gXnr7w+zI7OYSVewwABCK8lQqKaK6ZSpE4cxkM DevKLGvjLQkTGKvBpNXj0JBbdgVHbUjcZYPL8As5DDOF1894Zj42gKQS7eM+Hsz/uobn w8FQqkN4ORImuq3EGgrSYLZzPxBKAWzR8/gbBX9tXZtz6PzthmVq2gwIhHVGzadO7Lwa 0Kjw4ZivZTJFqIE9G14ye5uHY7jveIJ/bz7pEUhv7ROha9QlgNIZQ/HHehMPMboi4Bkg QAvg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=OsUHAGeI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y16si14697319pga.34.2019.04.27.06.56.18; Sat, 27 Apr 2019 06:56:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=OsUHAGeI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726378AbfD0NyO (ORCPT + 99 others); Sat, 27 Apr 2019 09:54:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:39412 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726079AbfD0NyN (ORCPT ); Sat, 27 Apr 2019 09:54:13 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8BFBD2087F; Sat, 27 Apr 2019 13:54:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556373253; bh=lJsqHSv7mbUunBcPqQKHgHokFLrEvLy8HZpkazORPD4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OsUHAGeITpwJkaOVGH/zpyWuVYSAdx6u+1wgeTyR5iyZRVsJqOp1AHqyfiMrL9FG6 PkesPUjQlBoShZ06zuefKy5fKixVGCm8OsWFxTMIDSM7BakIk3FcSW1ydXoPTxaO0P D+VNV/s1gbkc0FCucogEKRJ5dDvvLEi+CcX/XlTw= Date: Sat, 27 Apr 2019 15:54:10 +0200 From: "gregkh@linuxfoundation.org" To: Nathan Chancellor Cc: "Rantala, Tommi T. (Nokia - FI/Espoo)" , "linux-kernel@vger.kernel.org" , "sashal@kernel.org" , "tglx@linutronix.de" , "stable@vger.kernel.org" , "hpa@zytor.com" , "andi.kleen@intel.com" , "luto@kernel.org" , "joel@joelfernandes.org" , "astrachan@google.com" , "kernel-team@android.com" Subject: Re: [PATCH 4.14 09/69] x86: vdso: Use $LD instead of $CC to link Message-ID: <20190427135410.GA26744@kroah.com> References: <20190415183726.036654568@linuxfoundation.org> <20190415183728.632579553@linuxfoundation.org> <20190426124804.GA23970@archlinux-i9> <0dbe840a89d279be2b66d6c612d25eba4cc4c2e2.camel@nokia.com> <20190426133422.GA8796@archlinux-i9> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190426133422.GA8796@archlinux-i9> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 26, 2019 at 06:34:22AM -0700, Nathan Chancellor wrote: > On Fri, Apr 26, 2019 at 01:23:17PM +0000, Rantala, Tommi T. (Nokia - FI/Espoo) wrote: > > On Fri, 2019-04-26 at 05:48 -0700, Nathan Chancellor wrote: > > > On Fri, Apr 26, 2019 at 11:41:30AM +0000, Rantala, Tommi T. (Nokia - > > > FI/Espoo) wrote: > > > > On Mon, 2019-04-15 at 20:58 +0200, Greg Kroah-Hartman wrote: > > > > > commit 379d98ddf41344273d9718556f761420f4dc80b3 upstream. > > > > > > > > > > > > > Hi, > > > > > > > > With this patch in 4.14.112 build-id is now missing in vdso32.so: > > > > > > > > $ file arch/x86/entry/vdso/vdso*so* > > > > arch/x86/entry/vdso/vdso32.so: ELF 32-bit LSB pie executable, > > > > Intel > > > > 80386, version 1 (SYSV), dynamically linked, stripped > > > > arch/x86/entry/vdso/vdso32.so.dbg: ELF 32-bit LSB pie executable, > > > > Intel > > > > 80386, version 1 (SYSV), dynamically linked, with debug_info, not > > > > stripped > > > > arch/x86/entry/vdso/vdso64.so: ELF 64-bit LSB pie executable, > > > > x86- > > > > 64, version 1 (SYSV), dynamically linked, > > > > BuildID[sha1]=d80730a5b561a3161e488a369d1c76c250b584b4, stripped > > > > arch/x86/entry/vdso/vdso64.so.dbg: ELF 64-bit LSB pie executable, > > > > x86- > > > > 64, version 1 (SYSV), dynamically linked, > > > > BuildID[sha1]=d80730a5b561a3161e488a369d1c76c250b584b4, with > > > > debug_info, not stripped > > > > > > > > > > > > Based on quick check, "$(call ld-option, --build-id)" fails due to > > > > some > > > > 32/64 bit mismatch, so the --build-id linker flag is not used when > > > > linking vdso32.so > > > > > > > > Perhaps scripts/Kbuild.include is missing some change in 4.14.y to > > > > make > > > > this work properly. > > > > > > > > > > Hi Tommi, > > > > > > This appears to be fixed by commit 0294e6f4a000 ("kbuild: simplify > > > ld-option implementation") upstream. Could you test the attached > > > backport and make sure everything works on your end? Assuming that it > > > does, I will test the other stable releases and see if this is needed > > > and send those backports along. > > > > Yes this patch fixes it. Many thanks! > > Thanks for verifying! > > Greg, attached are backports for that commit for 4.4, 4.9, and 4.14. It > appeared in 4.16 so it is not needed with a newer version. Now queued up, thanks! greg k-h