Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Chengguang Xu <cgxu519@gmx.com>
To:     jack@suse.com
Cc:     linux-kernel@vger.kernel.org, Chengguang Xu <cgxu519@gmx.com>
Subject: [PATCH] quota: set init_needed flag only when successfully getting dquot
Date:   Sun, 28 Apr 2019 13:39:21 +0800
Message-Id: <20190428053921.5984-1-cgxu519@gmx.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Set init_needed flag only when successfully getting dquot,
so that we can skip unnecessary subsequent operation.

Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
=2D--
 fs/quota/dquot.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c
index fc20e06c56ba..8d4ce2a2b5c8 100644
=2D-- a/fs/quota/dquot.c
+++ b/fs/quota/dquot.c
@@ -1449,8 +1449,6 @@ static int __dquot_initialize(struct inode *inode, i=
nt type)
 		if (!sb_has_quota_active(sb, cnt))
 			continue;

-		init_needed =3D 1;
-
 		switch (cnt) {
 		case USRQUOTA:
 			qid =3D make_kqid_uid(inode->i_uid);
@@ -1475,6 +1473,9 @@ static int __dquot_initialize(struct inode *inode, i=
nt type)
 			dquot =3D NULL;
 		}
 		got[cnt] =3D dquot;
+
+		if (got[cnt])
+			init_needed =3D 1;
 	}

 	/* All required i_dquot has been initialized */
=2D-
2.20.1