Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 28 Apr 2019 09:12:15 +0200
Message-ID: <s5hef5mmwmo.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     "Wenwen Wang" <wang6495@umn.edu>
Cc:     "moderated list:SOUND" <alsa-devel@alsa-project.org>,
        "Jorge Sanjuan" <jorge.sanjuan@codethink.co.uk>,
        "Ruslan Bilovol" <ruslan.bilovol@gmail.com>,
        "Jaroslav Kysela" <perex@perex.cz>,
        "open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: usb-audio: Fix a memory leak bug
In-Reply-To: <1556345208-1210-1-git-send-email-wang6495@umn.edu>
References: <1556345208-1210-1-git-send-email-wang6495@umn.edu>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, 27 Apr 2019 08:06:46 +0200,
Wenwen Wang wrote:
> 
> In parse_audio_selector_unit(), the string array 'namelist' is allocated
> through kmalloc_array(), and each string pointer in this array, i.e.,
> 'namelist[]', is allocated through kmalloc() in the following for loop.
> Then, a control instance 'kctl' is created by invoking snd_ctl_new1(). If
> an error occurs during the creation process, the string array 'namelist',
> including all string pointers in the array 'namelist[]', should be freed,
> before the error code ENOMEM is returned. However, the current code does
> not free 'namelist[]', resulting in memory leaks.
> 
> To fix the above issue, free all string pointers 'namelist[]' in a loop.
> 
> Signed-off-by: Wenwen Wang <wang6495@umn.edu>

Applied now, thanks.


Takashi