Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 28 Apr 2019 10:33:54 +0100
Message-ID: <86sgu2a2yl.wl-marc.zyngier@arm.com>
From:   Marc Zyngier <marc.zyngier@arm.com>
To:     Anson Huang <anson.huang@nxp.com>
Cc:     Mukesh Ojha <mojha@codeaurora.org>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "jason@lakedaemon.net" <jason@lakedaemon.net>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH] irqchip/imx-irqsteer: use devm_platform_ioremap_resource() to simplify code
In-Reply-To: <DB3PR0402MB39165CB08BB94150215DE197F5380@DB3PR0402MB3916.eurprd04.prod.outlook.com>
References: <1554099427-5240-1-git-send-email-Anson.Huang@nxp.com>
        <e7f06738-6732-dc08-670d-ab78c985231f@codeaurora.org>
        <DB3PR0402MB39165CB08BB94150215DE197F5380@DB3PR0402MB3916.eurprd04.prod.outlook.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/26
 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO)
Organization: ARM Ltd
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, 28 Apr 2019 07:28:20 +0100,
Anson Huang <anson.huang@nxp.com> wrote:
> 
> Ping...

I'm still building the 5.2 branch, no need to panic just yet.

Thanks,

	M.

> 
> > -----Original Message-----
> > From: Mukesh Ojha [mailto:mojha@codeaurora.org]
> > Sent: Monday, April 1, 2019 3:47 PM
> > To: Anson Huang <anson.huang@nxp.com>; tglx@linutronix.de;
> > jason@lakedaemon.net; marc.zyngier@arm.com; shawnguo@kernel.org;
> > s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com;
> > linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org
> > Cc: dl-linux-imx <linux-imx@nxp.com>
> > Subject: Re: [PATCH] irqchip/imx-irqsteer: use
> > devm_platform_ioremap_resource() to simplify code
> > 
> > 
> > On 4/1/2019 11:51 AM, Anson Huang wrote:
> > > Use the new helper devm_platform_ioremap_resource() which wraps the
> > > platform_get_resource() and devm_ioremap_resource() together, to
> > > simplify the code.
> > >
> > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
> > 
> > Cheers,
> > -Mukesh
> > > ---
> > >   drivers/irqchip/irq-imx-irqsteer.c | 4 +---
> > >   1 file changed, 1 insertion(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/irqchip/irq-imx-irqsteer.c
> > > b/drivers/irqchip/irq-imx-irqsteer.c
> > > index 88df3d00..290531e 100644
> > > --- a/drivers/irqchip/irq-imx-irqsteer.c
> > > +++ b/drivers/irqchip/irq-imx-irqsteer.c
> > > @@ -144,7 +144,6 @@ static int imx_irqsteer_probe(struct
> > platform_device *pdev)
> > >   {
> > >   	struct device_node *np = pdev->dev.of_node;
> > >   	struct irqsteer_data *data;
> > > -	struct resource *res;
> > >   	u32 irqs_num;
> > >   	int i, ret;
> > >
> > > @@ -152,8 +151,7 @@ static int imx_irqsteer_probe(struct
> > platform_device *pdev)
> > >   	if (!data)
> > >   		return -ENOMEM;
> > >
> > > -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > > -	data->regs = devm_ioremap_resource(&pdev->dev, res);
> > > +	data->regs = devm_platform_ioremap_resource(pdev, 0);
> > >   	if (IS_ERR(data->regs)) {
> > >   		dev_err(&pdev->dev, "failed to initialize reg\n");
> > >   		return PTR_ERR(data->regs);

-- 
Jazz is not dead, it just smell funny.