Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 28 Apr 2019 21:58:34 +1000
From:   Nicholas Piggin <npiggin@gmail.com>
Subject: Re: [PATCH] kernel/sched: run nohz idle load balancer on HK_FLAG_MISC
 CPUs
To:     Wanpeng Li <kernellwp@gmail.com>
Cc:     Frederic Weisbecker <fweisbec@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>
References: <20190412042613.28930-1-npiggin@gmail.com>
        <CANRm+CzLmRHtpAawBSknXyznw25ym_otnYJYYxAho-E46K3BZg@mail.gmail.com>
In-Reply-To: <CANRm+CzLmRHtpAawBSknXyznw25ym_otnYJYYxAho-E46K3BZg@mail.gmail.com>
MIME-Version: 1.0
User-Agent: astroid/0.14.0 (https://github.com/astroidmail/astroid)
Message-Id: <1556452479.a2f15ax2p1.astroid@bobo.none>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Wanpeng Li's on April 28, 2019 5:01 pm:
> On Fri, 12 Apr 2019 at 12:27, Nicholas Piggin <npiggin@gmail.com> wrote:
>>
>> The nohz idle balancer runs on the lowest idle CPU. This can
>> interfere with isolated CPUs, so confine it to HK_FLAG_MISC
>> housekeeping CPUs.
>>
>> HK_FLAG_SCHED is not used for this because it is not set anywhere
>> at the moment. This could be folded into HK_FLAG_SCHED once that
>> option is fixed.
>>
>> The problem was observed with increased jitter on an application
>> running on CPU0, caused by nohz idle load balancing being run on
>> CPU1 (an SMT sibling).
>>
>> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
>> ---
>>  kernel/sched/fair.c | 16 ++++++++++------
>>  1 file changed, 10 insertions(+), 6 deletions(-)
>>
>> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
>> index fdab7eb6f351..d29ca323214d 100644
>> --- a/kernel/sched/fair.c
>> +++ b/kernel/sched/fair.c
>> @@ -9522,22 +9522,26 @@ static inline int on_null_domain(struct rq *rq)
>>   * - When one of the busy CPUs notice that there may be an idle rebalan=
cing
>>   *   needed, they will kick the idle load balancer, which then does idl=
e
>>   *   load balancing for all the idle CPUs.
>> + * - HK_FLAG_MISC CPUs are used for this task, because HK_FLAG_SCHED no=
t set
>> + *   anywhere yet.
>>   */
>>
>>  static inline int find_new_ilb(void)
>>  {
>> -       int ilb =3D cpumask_first(nohz.idle_cpus_mask);
>> +       int ilb;
>>
>> -       if (ilb < nr_cpu_ids && idle_cpu(ilb))
>> -               return ilb;
>> +       for_each_cpu_and(ilb, nohz.idle_cpus_mask,
>> +                             housekeeping_cpumask(HK_FLAG_MISC)) {
>> +               if (idle_cpu(ilb))
>> +                       return ilb;
>> +       }
>=20
> What will happen if cpu1 is still idle currently && housekeeping?

Then it will run the ilb.

In the customer scenario, cpu1 will not be in the housekeeping mask.

Thanks,
Nick

=