Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2643629yba; Sun, 28 Apr 2019 05:55:10 -0700 (PDT) X-Google-Smtp-Source: APXvYqwztjhQFPDBwrFH3jfdvZY3mbOwA4zMJSuqhp/v370Ib9rxan9IuukJzDftQvVE2Ajdk0PM X-Received: by 2002:a62:292:: with SMTP id 140mr59039111pfc.206.1556456109943; Sun, 28 Apr 2019 05:55:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556456109; cv=none; d=google.com; s=arc-20160816; b=qJWBxU5ZmZ8G9td0EodFiTCd3dX7DDn6oGtIDROgQszQZSCXcFttBOvcAh4/3va615 kHgKUPcCsoeL2U+6O1wW47AUAb2jAEFrAH7sWh0U6zQxvEFctITDibv4wiGm9RFJ9+Ht A/ifwnalRJ4769EtYl4UFhVGk/G/mMZNUUPax1pWTMG6CDEDU/UhXobLdLvZskgZvVC6 OAz+66NwFavwDnlf6mGuh3EbphhgrPK8BFm0nrGl8YpzKhNKAu2cE+/jAhcOLPimwNVI M9VV0MMzhUB9IBuy2DAapOymoApMtMfxzT9qkNHWl4zyn591Sle8cSri2w+5QJE1D8XC DSXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=jbQ2n1Xv81jl0FiXQUNyBwoT28L8JeYdcoEKTfjgOww=; b=vL0f1yxDf1kGGfmYHB5dZhtTKqgJtNMeRleHt9TNe9eCMsHi7kp1PA7kLFNWhSFERZ FgdCgWEahuxmcn8HKLLFDuYrHP/CtkRrjtroQ/0/VCSNcsmcUnhgAGPb4HKUphlDxI86 dqR1YSyFWbVmAqHLUJSoxNAn2ZjhqEJNPb317+9/kdPgToUkJJDp2rPlkEU6joYV0+IH kqIX0xcG1OdfHFlqDBXS+xfe8/V5J7hj3xaMUA/q9JR40ChX5f15SjOWr4S/JtKtiRMR YqV0gWGK+YgCOO8igpaRAmNz3doV5vh8F4IBsO3URzsx6VpuANKH6+9Kf3P38/c96Fv3 K0qw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 30si30490529plb.235.2019.04.28.05.54.55; Sun, 28 Apr 2019 05:55:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726885AbfD1MyA (ORCPT + 99 others); Sun, 28 Apr 2019 08:54:00 -0400 Received: from smtp-out.xnet.cz ([178.217.244.18]:45774 "EHLO smtp-out.xnet.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726780AbfD1Mxt (ORCPT ); Sun, 28 Apr 2019 08:53:49 -0400 Received: from meh.true.cz (meh.true.cz [108.61.167.218]) (Authenticated sender: petr@true.cz) by smtp-out.xnet.cz (Postfix) with ESMTPSA id 7DB83453C; Sun, 28 Apr 2019 14:53:46 +0200 (CEST) Received: by meh.true.cz (OpenSMTPD) with ESMTP id 4540dc20; Sun, 28 Apr 2019 14:53:45 +0200 (CEST) From: =?UTF-8?q?Petr=20=C5=A0tetiar?= To: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Grygorii Strashko , "David S. Miller" Cc: Andrew Lunn , Florian Fainelli , Heiner Kallweit , Rob Herring , Frank Rowand , Srinivas Kandagatla , Maxime Ripard , Alban Bedel , =?UTF-8?q?Petr=20=C5=A0tetiar?= , linux-omap@vger.kernel.org Subject: [PATCH v2 4/4] net: davinci_emac: Drop nvmem_get_mac_address usage Date: Sun, 28 Apr 2019 14:53:22 +0200 Message-Id: <1556456002-13430-5-git-send-email-ynezz@true.cz> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1556456002-13430-1-git-send-email-ynezz@true.cz> References: <1556456002-13430-1-git-send-email-ynezz@true.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org of_get_mac_address now uses NVMEM under the hood, so it's not necessary to call it manually anymore. Signed-off-by: Petr Štetiar --- drivers/net/ethernet/ti/davinci_emac.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/net/ethernet/ti/davinci_emac.c b/drivers/net/ethernet/ti/davinci_emac.c index 57450b1..c1a5526 100644 --- a/drivers/net/ethernet/ti/davinci_emac.c +++ b/drivers/net/ethernet/ti/davinci_emac.c @@ -1912,15 +1912,11 @@ static int davinci_emac_probe(struct platform_device *pdev) ether_addr_copy(ndev->dev_addr, priv->mac_addr); if (!is_valid_ether_addr(priv->mac_addr)) { - /* Try nvmem if MAC wasn't passed over pdata or DT. */ - rc = nvmem_get_mac_address(&pdev->dev, priv->mac_addr); - if (rc) { - /* Use random MAC if still none obtained. */ - eth_hw_addr_random(ndev); - memcpy(priv->mac_addr, ndev->dev_addr, ndev->addr_len); - dev_warn(&pdev->dev, "using random MAC addr: %pM\n", - priv->mac_addr); - } + /* Use random MAC if still none obtained. */ + eth_hw_addr_random(ndev); + memcpy(priv->mac_addr, ndev->dev_addr, ndev->addr_len); + dev_warn(&pdev->dev, "using random MAC addr: %pM\n", + priv->mac_addr); } ndev->netdev_ops = &emac_netdev_ops; -- 1.9.1