Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2780516yba; Sun, 28 Apr 2019 08:53:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqzlQMamRxsfyMKTq+/Sl0sYF25uIqpNiYfN83xah4hGfBsZ4uHkBjWTYMfADpdC777j2fGe X-Received: by 2002:aa7:9285:: with SMTP id j5mr29677254pfa.129.1556466812972; Sun, 28 Apr 2019 08:53:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556466812; cv=none; d=google.com; s=arc-20160816; b=KHgBgPbUmGbam4lLLMFPR1zCaAOgQTh4SqmESY98Vu+IasK/UbBOwTbU662+980IPL XX++ZjFmr1/QgtEeTbpF32uk5+omGKnZqTbRoySi5U67w8o8V2U+1LPDLtS4Q8JRkMRc NyJ0UNoDiRtpMRwZO7Z2SL+RDu4KgWfaxRR/ZkBiUeuxoMgiZCSDIvFTcogXqqiv97zJ kPTDl88Cv2a321/xNcvwPKWq4lXKcgICnijvSyG5ru6EQtZUW2fk/NE1RUxMrV2Fj6Bf bUpYriBq84yia1gDrKg7RqDjgEQ56ZWyHhWrC+G4zLUUdUBPB/T4gYO1uWkbeU2LnJIQ yIdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=u5mCTgj0R7vnYgSmel7mpXPly8wSBX//we8z56maNhs=; b=e8Ol5gzVCxzNZ4cb6EuLkFGTD960u3DNErVoNffdYcNTSGXZbZH0LKSj1TpZuuknKL MuZkBCnRwnZJ4YUE2sH6ZeZRp/Of42mLPHwIzJOUVvzVYwoCgiaiwz4425AlMshPRBUM MLiq6hJ+VsZHkz8NCncz1wPtfXyvy6wODVEr9Ap27C6GD8L+xuD/5VCTXy8a5UPMqow9 1+V+AbLTBR7QTedro7JHLkRYG+/tkkdEX/ca6+hk1ih5MLb8GyL5rM64G37qs2TczsYM Ib8ZiHPEddEDK/CqX6+zYHKItOHXK/N87NyaDnnaMOtr3tmP2J7xYF0NQrEaS+u+iRq0 PmNw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z6si408392pgc.329.2019.04.28.08.53.17; Sun, 28 Apr 2019 08:53:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726884AbfD1PwW (ORCPT + 99 others); Sun, 28 Apr 2019 11:52:22 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:41120 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726744AbfD1PwW (ORCPT ); Sun, 28 Apr 2019 11:52:22 -0400 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92 #3 (Red Hat Linux)) id 1hKm6C-0003LZ-QR; Sun, 28 Apr 2019 15:52:16 +0000 Date: Sun, 28 Apr 2019 16:52:16 +0100 From: Al Viro To: Jeff Layton Cc: Linus Torvalds , Ilya Dryomov , ceph-devel@vger.kernel.org, Linux List Kernel Mailing , linux-cifs Subject: Re: [GIT PULL] Ceph fixes for 5.1-rc7 Message-ID: <20190428155216.GB23075@ZenIV.linux.org.uk> References: <342ef35feb1110197108068d10e518742823a210.camel@kernel.org> <20190425200941.GW2217@ZenIV.linux.org.uk> <86674e79e9f24e81feda75bc3c0dd4215604ffa5.camel@kernel.org> <20190426165055.GY2217@ZenIV.linux.org.uk> <20190428043801.GE2217@ZenIV.linux.org.uk> <7bac7ba5655a8e783a70f915853a0846e7ff143b.camel@kernel.org> <20190428144850.GA23075@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 28, 2019 at 11:47:58AM -0400, Jeff Layton wrote: > We could stick that in ceph_dentry_info (->d_fsdata). We have a flags > field in there already. Yes, but... You have it freed in ->d_release(), AFAICS, and without any delays. So lockless accesses will be trouble.