Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2827479yba; Sun, 28 Apr 2019 09:59:00 -0700 (PDT) X-Google-Smtp-Source: APXvYqzD9KCtcfh37/wdsYzMes+BrWe0UZR7NFKCkH1F7Ump0fmikb6wuZ2y5P22ta/sJzSOmlZ3 X-Received: by 2002:aa7:91d5:: with SMTP id z21mr58457234pfa.222.1556470740836; Sun, 28 Apr 2019 09:59:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556470740; cv=none; d=google.com; s=arc-20160816; b=vy9zaCosg0OxSG6/jsaQQvol7zQ7u/z7PPQOuSfETc0uj5DSFLvDBvYSNJ1jRaakIP OPh852RDhFhWi5t6BA8a5Kz4meJjid9xs8QMLlY+/wRGYwTepRvW584ztw17qQPsT3ft Z8O0V/g/5rQ1PJenDtoEFNID4Gt/BGlvsYtI4JLtzStFo56wVNo0dhrcJbZoZ66Hg+yE /P4GJnWeYv1699Dgm6UuLXkjVRsNPmDcMIEBxN7HKLlWTdLjtknvLxFIKc+oRRic/pNw ZrH1hOCfBzPsfmRXKmkQ7yy4UupUJJzMEErPVYT7417R7n4+jXWmSFbCLhCsZLarm6ej XWPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Eur4MdCzKORc+1WMkF8IVNyhBHWvA4WHKALxwGbm9Yc=; b=Q8gKnlh2ReSGT9EnO/yu/AvljDeIG/jnwlExlNg/d7cy4+gPKKUJv7WL3XCGyY+qfJ lbISDyLJZIAqcYkHtmy6yfpn/cd1dQCexyqJmg+v7uayp0Ez4nrX54t9OPskygvZhMp1 D36LLr7lRXwcSkZTMlGRdA7hz8jlZssfRSzPlErUxOWDmq35NGPOqDd8maK/EQovHfPB Jt2TA8cQBonn8MxEGUjxTFUCg0NDEJc5x3V0jvFWIo+Z4s58kkueJaJoJjDSIskYa51s 8yUmYQcftuwojVw1sDw3MSn2Ruvx7jFesyQKqxGSgqroVYZqTaijP0N9y0MpriyoQf8C egsQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@lunn.ch header.s=20171124 header.b="00m/+zxj"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k1si9664652pgs.179.2019.04.28.09.58.45; Sun, 28 Apr 2019 09:59:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@lunn.ch header.s=20171124 header.b="00m/+zxj"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727012AbfD1Q4k (ORCPT + 99 others); Sun, 28 Apr 2019 12:56:40 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:47391 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726220AbfD1Q4j (ORCPT ); Sun, 28 Apr 2019 12:56:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Eur4MdCzKORc+1WMkF8IVNyhBHWvA4WHKALxwGbm9Yc=; b=00m/+zxjdq3Lp5U/b6UuJgpMP2 ELBRaPLmtQEC2wA81NiqOb3mFWu/UWKfPXnZm7yJA+ZxO3LZlQtlyaOqEk27b/9xwbxWZkUPJ/b6b rBHzQ6JLYUqnmUFJxfEQPLofmDhuCHvFzwKolEw3dxr8FqjmGLWFML5VTv/RLibxaf9k=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hKn6T-0000xo-Fb; Sun, 28 Apr 2019 18:56:37 +0200 Date: Sun, 28 Apr 2019 18:56:37 +0200 From: Andrew Lunn To: Petr =?utf-8?Q?=C5=A0tetiar?= Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Nicolas Ferre , "David S. Miller" , Florian Fainelli , Heiner Kallweit , Rob Herring , Frank Rowand , Srinivas Kandagatla , Maxime Ripard , Alban Bedel Subject: Re: [PATCH v2 3/4] net: macb: Drop nvmem_get_mac_address usage Message-ID: <20190428165637.GJ23059@lunn.ch> References: <1556456002-13430-1-git-send-email-ynezz@true.cz> <1556456002-13430-4-git-send-email-ynezz@true.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1556456002-13430-4-git-send-email-ynezz@true.cz> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 28, 2019 at 02:53:21PM +0200, Petr Štetiar wrote: > of_get_mac_address now uses NVMEM under the hood, so it's not necessary > to call it manually anymore. > > Signed-off-by: Petr Štetiar > --- > drivers/net/ethernet/cadence/macb_main.c | 12 +++--------- > 1 file changed, 3 insertions(+), 9 deletions(-) > > diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c > index 3da2795..1b98bc8 100644 > --- a/drivers/net/ethernet/cadence/macb_main.c > +++ b/drivers/net/ethernet/cadence/macb_main.c > @@ -4172,16 +4172,10 @@ static int macb_probe(struct platform_device *pdev) > bp->rx_intr_mask |= MACB_BIT(RXUBR); > > mac = of_get_mac_address(np); > - if (mac) { > + if (mac) > ether_addr_copy(bp->dev->dev_addr, mac); > - } else { > - err = nvmem_get_mac_address(&pdev->dev, bp->dev->dev_addr); > - if (err) { > - if (err == -EPROBE_DEFER) The EPRODE_DEFER is interesting here. your change to of_get_mac_address() does not seem to handle that case. It probably should. We don't want it to fail and end up with a random MAC addresses etc, because the NVMEM has not probed yet. Andrew