Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2986758yba; Sun, 28 Apr 2019 14:10:09 -0700 (PDT) X-Google-Smtp-Source: APXvYqyTEfK09KMmv09sOox2yotuHgt/QlTOCaWfAUDMekJlOdfe7oF62RKiiXF594Sk0BNn0DmZ X-Received: by 2002:a62:2b4e:: with SMTP id r75mr8841747pfr.131.1556485808996; Sun, 28 Apr 2019 14:10:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556485808; cv=none; d=google.com; s=arc-20160816; b=jWko+eBm9vRuHDUipMomqoQ9dt5ns2P6D49G4sXMqsRpzPyd2vOQ2NfmLXvrV2uaEK cV+gVi3RYP4n614fDOWaV+K3pKehojgYUN1mq29lAM4UV7VwMaFqmHSURV8/12l7kvFA IxfxXiCF+rbLlDUScGOF6IkRnG7B7yInw9kzF8ok/poaXBlyQlV0RilcXhugV5Tw9Fb4 uVO7KA5rR1SubCKJZXcpHfo+hOh4fMniJAk/ML1nNljXXO3l4Vjsm+CXvhsaB8G8s9E3 QvI0uCjuvo0rD5Pd0F+hg1zvZzEDXJKkFWUx+tHIw3F/KWKDnOK8YJw7J0RcNoDjLIXI eUng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:reply-to:message-id :subject:cc:to:from:date; bh=7CZoP00TOsjocdfwyrq0qzFxDr0QXlyDa6U5CYY53DA=; b=Ia0pAAzJLhQ6R6uIRTPEeqjKwUbyYE3t/XFCFNZNxxUxCXtrR0MBrzSNcIywnCDoMD dlnMFl16V+uKHzojVuZKT59IN6+VLPrWi5jFpWFW3uw2yk223MqHFCCv3n/7IFVDbBkN J3R51x7zD2v1rOoX0Y9JF9eVNLu3YXzcZ5elI5tdr3A2znnOMxnRsOPnhN5BIqBAQaGu DF0QpPs6NZzin6IvvcDPPhXG4G/vfzFQbFBDjlZhepgn25Ae+0rUxEAT35gVZ8nmBVFu LGO/FlGJadnqbihxWPMvbp5CZ5R/CBnK+BkiQ1pmX/ExbbEJtVIUq45rXy2Lxl2+H2+X ksVg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 1si31937915plo.217.2019.04.28.14.09.42; Sun, 28 Apr 2019 14:10:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726495AbfD1VIU (ORCPT + 99 others); Sun, 28 Apr 2019 17:08:20 -0400 Received: from smtp-out.xnet.cz ([178.217.244.18]:37603 "EHLO smtp-out.xnet.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725982AbfD1VIU (ORCPT ); Sun, 28 Apr 2019 17:08:20 -0400 Received: from meh.true.cz (meh.true.cz [108.61.167.218]) (Authenticated sender: petr@true.cz) by smtp-out.xnet.cz (Postfix) with ESMTPSA id A0BEE3417; Sun, 28 Apr 2019 23:08:16 +0200 (CEST) Received: from localhost (meh.true.cz [local]) by meh.true.cz (OpenSMTPD) with ESMTPA id 818325c1; Sun, 28 Apr 2019 23:08:15 +0200 (CEST) Date: Sun, 28 Apr 2019 23:08:14 +0200 From: Petr =?utf-8?Q?=C5=A0tetiar?= To: Andrew Lunn Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Nicolas Ferre , "David S. Miller" , Florian Fainelli , Heiner Kallweit , Rob Herring , Frank Rowand , Srinivas Kandagatla , Maxime Ripard , Alban Bedel Subject: Re: [PATCH v2 3/4] net: macb: Drop nvmem_get_mac_address usage Message-ID: <20190428210814.GA346@meh.true.cz> Reply-To: Petr =?utf-8?Q?=C5=A0tetiar?= References: <1556456002-13430-1-git-send-email-ynezz@true.cz> <1556456002-13430-4-git-send-email-ynezz@true.cz> <20190428165637.GJ23059@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190428165637.GJ23059@lunn.ch> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andrew Lunn [2019-04-28 18:56:37]: Hi Andrew, > On Sun, Apr 28, 2019 at 02:53:21PM +0200, Petr Štetiar wrote: > > of_get_mac_address now uses NVMEM under the hood, so it's not necessary > > to call it manually anymore. > > > > Signed-off-by: Petr Štetiar > > --- > > drivers/net/ethernet/cadence/macb_main.c | 12 +++--------- > > 1 file changed, 3 insertions(+), 9 deletions(-) > > > > diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c > > index 3da2795..1b98bc8 100644 > > --- a/drivers/net/ethernet/cadence/macb_main.c > > +++ b/drivers/net/ethernet/cadence/macb_main.c > > @@ -4172,16 +4172,10 @@ static int macb_probe(struct platform_device *pdev) > > bp->rx_intr_mask |= MACB_BIT(RXUBR); > > > > mac = of_get_mac_address(np); > > - if (mac) { > > + if (mac) > > ether_addr_copy(bp->dev->dev_addr, mac); > > - } else { > > - err = nvmem_get_mac_address(&pdev->dev, bp->dev->dev_addr); > > - if (err) { > > - if (err == -EPROBE_DEFER) > > The EPRODE_DEFER is interesting here. your change to > of_get_mac_address() does not seem to handle that case. It probably > should. We don't want it to fail and end up with a random MAC > addresses etc, because the NVMEM has not probed yet. so if I understand this correctly, it probably means, that this approach with modified of_get_mac_address is dead end as current of_get_mac_address users don't expect and handle possible -EPROBE_DEFER error, so I would need to change all the current users, which is nonsense. -- ynezz