Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3003453yba; Sun, 28 Apr 2019 14:37:57 -0700 (PDT) X-Google-Smtp-Source: APXvYqwY/7z+6ZyAt6Ig1uXIgHfwPyGXb1PQhiiaMc8ARJOf8gtYdNKXOR86n4TInGw3iYXQDAuH X-Received: by 2002:a63:c145:: with SMTP id p5mr54855519pgi.339.1556487477553; Sun, 28 Apr 2019 14:37:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556487477; cv=none; d=google.com; s=arc-20160816; b=keWFkgPwSI4x48sO4ZPgZBOBfvitvBEQu8DsgTHn58S2/YebY4p0URN2e6OQQahSDt Z8VA1yq3EGzQZggreJA0trbU6X6mr2jm37jr/vC31n0SE/fdsArRKb/X/L142dBA6toV vhTSpykbxHO7hF0stsZ6HLIVWU4XhDXwaZZVTCGC3J9Qi+nx+fkKQBWoeOHuBgd1vEc9 jbfWbG/u04K6ptcGXhBmEa8ZV1zJVpZqIO7zSWjOoYNbd5xaePeKfGxO0Z1oJz39gIRY 97Vy552YGn4Da4rN5H98+J65kz86IrrRJXgjfEIfOom/tWdKp1nomyQwketBxv6SiwQ6 Sv8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=sNLTtMpLfiCg0JHlqA74ro0TLCE0R75diXWV66fsyvs=; b=n5VfrwWIoUIcI16Cjz+Ht+GA3tpMJJ50jvwxP6ZD1P1qU429bx5DsgVkVobdrjuj7Y zUcRSgsRArnNqX6f2qcpnCYJA/aaTqIvxZgXUv7jrCvfTSaGsb8sfIeLgSoiIukgm2HF Mhax7rcPcn0wknZ9GOcxHlpr9672LOlRRO7pb+/zkf2uaSxrMX9jGI2LWJt455zUIHCw zAaKB92qOLQtu1541PT4VGcrIi9qnxrWA3Fm7V010gfv+TfJ59OqAerx4ipYsEzygVAJ eR09Za8+hOd9L1UmPaMuhnnLuwN7nP2E2vJ6yzVG+HBMLhHp9yRxkidcZdMbPsPOHUZ3 I99g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@lunn.ch header.s=20171124 header.b="i4BThc/7"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j15si31227941pfi.8.2019.04.28.14.37.39; Sun, 28 Apr 2019 14:37:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@lunn.ch header.s=20171124 header.b="i4BThc/7"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726539AbfD1Vgp (ORCPT + 99 others); Sun, 28 Apr 2019 17:36:45 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:47818 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726393AbfD1Vgp (ORCPT ); Sun, 28 Apr 2019 17:36:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=sNLTtMpLfiCg0JHlqA74ro0TLCE0R75diXWV66fsyvs=; b=i4BThc/7ZQrBMZ9MjVf43xKkd9 rhdeY3pPFHKHaiaOOlioQR9QwyMOVG9S2oU3yZYKO3IZWXTvt68zZAEe0GhvD5289wuoabHXhW81V tBHUZbjuz+RnOihXHjyqrxK32PVniJqD+gPs755dg93XdgkqQuEFSOjSbbL8NLGWLMbk=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hKrTU-00032d-Pc; Sun, 28 Apr 2019 23:36:40 +0200 Date: Sun, 28 Apr 2019 23:36:40 +0200 From: Andrew Lunn To: Petr =?utf-8?Q?=C5=A0tetiar?= Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Nicolas Ferre , "David S. Miller" , Florian Fainelli , Heiner Kallweit , Rob Herring , Frank Rowand , Srinivas Kandagatla , Maxime Ripard , Alban Bedel Subject: Re: [PATCH v2 3/4] net: macb: Drop nvmem_get_mac_address usage Message-ID: <20190428213640.GB10772@lunn.ch> References: <1556456002-13430-1-git-send-email-ynezz@true.cz> <1556456002-13430-4-git-send-email-ynezz@true.cz> <20190428165637.GJ23059@lunn.ch> <20190428210814.GA346@meh.true.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190428210814.GA346@meh.true.cz> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > so if I understand this correctly, it probably means, that this approach with > modified of_get_mac_address is dead end as current of_get_mac_address users > don't expect and handle possible -EPROBE_DEFER error, so I would need to > change all the current users, which is nonsense. Hi Petr I would not say it is dead, it just needs a bit more work. The current users should always be checking for a NULL pointer. You just need to change that to !IS_ERR(). You can then return ERR_PTR(-PROBE_DEFER) from the NVMEM operation. And i agree, wrapping this all up inside of_get_mac_address() is the correct way to do this. Andrew