Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262850AbVA2Edz (ORCPT ); Fri, 28 Jan 2005 23:33:55 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262851AbVA2Edz (ORCPT ); Fri, 28 Jan 2005 23:33:55 -0500 Received: from mail.kroah.org ([69.55.234.183]:50410 "EHLO perch.kroah.org") by vger.kernel.org with ESMTP id S262850AbVA2Ecv (ORCPT ); Fri, 28 Jan 2005 23:32:51 -0500 Date: Fri, 28 Jan 2005 20:06:47 -0800 From: Greg KH To: Christoph Hellwig , brking@us.ibm.com, linux-kernel@vger.kernel.org, linuxppc64-dev@ozlabs.org Subject: Re: [PATCH 1/2] pci: Arch hook to determine config space size Message-ID: <20050129040647.GA6261@kroah.com> References: <200501281456.j0SEuI12020454@d01av01.pok.ibm.com> <20050128185234.GB21760@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050128185234.GB21760@infradead.org> User-Agent: Mutt/1.5.6i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 646 Lines: 19 On Fri, Jan 28, 2005 at 06:52:34PM +0000, Christoph Hellwig wrote: > > +int __attribute__ ((weak)) pcibios_exp_cfg_space(struct pci_dev *dev) { return 1; } > > - prototypes belong to headers > - weak linkage is the perfect way for total obsfucation > > please make this a regular arch hook I agree. Also, when sending PCI related patches, please cc the linux-pci mailing list. thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/