Date: Mon, 31 Jan 2005 22:53:12 +0100
From: Adrian Bunk <bunk@stusta.de>
To: Stelian Pop <stelian@popies.net>, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] drivers/char/sonypi.c: make 3 structs static
Message-ID: <20050131215312.GG21437@stusta.de>
References: <20050131173508.GS18316@stusta.de> <20050131214905.GF28886@deep-space-9.dsnet>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20050131214905.GF28886@deep-space-9.dsnet>
User-Agent: Mutt/1.5.6+20040907i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1248
Lines: 39

On Mon, Jan 31, 2005 at 10:49:05PM +0100, Stelian Pop wrote:
> On Mon, Jan 31, 2005 at 06:35:08PM +0100, Adrian Bunk wrote:
> 
> > This patch makes three needlessly global structs static.
> > 
> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
> > 
> > ---
> > 
> >  drivers/char/sonypi.c |   76 +++++++++++++++++++++++++++++++++++++++++-
> >  drivers/char/sonypi.h |   74 ----------------------------------------
> >  2 files changed, 75 insertions(+), 75 deletions(-)
> 
> sonypi.h is a "local" header file used only by sonypi.c.
> 
> I would like to keep those tables in sonypi.h rather than putting 
> all into sonypi.c (or we could as well remove sonypi.h and put all the
> contents into the .c).
> 
> What about:
>...

That's also OK with me.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/